TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay/0 is failing with SingleProcessMash |
|||
Issue descriptionTabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay/0 is still failing with SingleProcessMash.
,
Nov 5
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2712c58b1c0bcaae9c520bea65710a0bb01b1de7 commit 2712c58b1c0bcaae9c520bea65710a0bb01b1de7 Author: Jun Mukai <mukai@chromium.org> Date: Tue Nov 06 18:00:46 2018 Fix of DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay for Mash This CL fixes DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay of tab-dragging for Mash; - SetBounds are not great for testing with Mash since it may not reflect the correct location in Ash, or it may cause moving the browser window to the secondary display. Instead, dragging events to move the browser window which still resides in the primary display but covers on the secondary display. - Creates a mouse move event on the warped pointer; as far as I debugged, this is not happening in the classic environment too, but the test was passing somehow (the newly added expectation of browser bounds at the end fails even without Mash). BUG= 901543 TEST=trybot Change-Id: Id4826673975535e0dc12460cda4a62b060a328db Reviewed-on: https://chromium-review.googlesource.com/c/1318794 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605734} [modify] https://crrev.com/2712c58b1c0bcaae9c520bea65710a0bb01b1de7/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/2712c58b1c0bcaae9c520bea65710a0bb01b1de7/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
,
Nov 6
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mukai@chromium.org
, Nov 2