TabDragController sees 1-frame older touch location when dragging with touch |
|||
Issue descriptionTabDragging/DetachToBrowserTabDragControllerTest.DragToSeparateWindow/1 is still failing with SingleProcessMash.
,
Nov 5
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfc78a0a51d3bb81ca3b5464899c14c8be38e5e1 commit bfc78a0a51d3bb81ca3b5464899c14c8be38e5e1 Author: Jun Mukai <mukai@chromium.org> Date: Wed Nov 07 01:38:52 2018 Fix the last touch point in Mus Currently GestureRecognizerImplMus recceives the last touch point location through ui::EventObserver (which is supplied through ObserveEventTypes() mojo call). However, during window move, this can be late since the OnObservedInputEvent will be called after processing other event handlings in the window server. As is written in the bug, if the client observes through OnBoundsChanged(), this bounds change happens in the client before OnObservedInputEvent. This results with GetLastTouchPointForTarget returning 1-frame older location. This isn't quite observable on normal user operation but has significant differences on test scenario. Instead of observing the input, it can simply remember the offset of the touch location when the window move starts. BUG= 901540 TEST=see the filter update Change-Id: I84bf19d9b705ec582b5359383a914b19c506adf9 Reviewed-on: https://chromium-review.googlesource.com/c/1321257 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605921} [modify] https://crrev.com/bfc78a0a51d3bb81ca3b5464899c14c8be38e5e1/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter [modify] https://crrev.com/bfc78a0a51d3bb81ca3b5464899c14c8be38e5e1/ui/aura/mus/gesture_recognizer_impl_mus.cc [modify] https://crrev.com/bfc78a0a51d3bb81ca3b5464899c14c8be38e5e1/ui/aura/mus/gesture_recognizer_impl_mus.h
,
Nov 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mukai@chromium.org
, Nov 2