Low-latency issue on Nocturne |
|||||||||||||||
Issue descriptionChrome Version: 72.0.3593.0 canary OS Version: 11218.0.0 What steps will reproduce the problem? 1. Install Squid from Play Store 2. Enter tablet mode by detaching keyboard (or simply maximize app) 3. Try drawing a straight line with stylus. Notice lag. 3. Hide shelf. 4. Try drawing a straight line with stylus. Notice no lag. What is the expected result? There shouldn't be lag in either case What happens instead of that? There is lag when shelf is visible. App is unable to get hw overlay. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 11210.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3593.0 Safari/537.36
,
Nov 7
,
Nov 7
Repros in M-72 so bumping it.
,
Nov 7
It does look to me a bug in compositor, and I have a workaround. And this probably happens in 71 because the CL introduced this has been merged to71.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc8967075ab8cf77627863845dc4a3af22b47f88 commit bc8967075ab8cf77627863845dc4a3af22b47f88 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Nov 07 22:43:30 2018 Use 0xFE opacity for sheld in maximized state. This is a workaround. Using fully opaque color somehow causes the content clipping on the arc content window. It'll be investigated separately. Bug: 901538 Test: manual. Change-Id: Ifee1ccdeb3e877008f33ef62ba1dd5024bb4b196 Reviewed-on: https://chromium-review.googlesource.com/c/1324393 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606185} [modify] https://crrev.com/bc8967075ab8cf77627863845dc4a3af22b47f88/ash/shelf/shelf_constants.h
,
Nov 7
Very low risk CL that should fix the performance issue in m71 as well.
,
Nov 8
,
Nov 8
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8
Approved for M71 ChromeOS
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41b48da8efaaf9a0a9f7dda970d94898909d6dbb commit 41b48da8efaaf9a0a9f7dda970d94898909d6dbb Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Nov 09 01:27:15 2018 Use 0xFE opacity for sheld in maximized state. This is a workaround. Using fully opaque color somehow causes the content clipping on the arc content window. It'll be investigated separately. Bug: 901538 Test: manual. Change-Id: Ifee1ccdeb3e877008f33ef62ba1dd5024bb4b196 Reviewed-on: https://chromium-review.googlesource.com/c/1324393 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606185}(cherry picked from commit bc8967075ab8cf77627863845dc4a3af22b47f88) Reviewed-on: https://chromium-review.googlesource.com/c/1328181 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#598} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/41b48da8efaaf9a0a9f7dda970d94898909d6dbb/ash/shelf/shelf_constants.h
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41b48da8efaaf9a0a9f7dda970d94898909d6dbb Commit: 41b48da8efaaf9a0a9f7dda970d94898909d6dbb Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-09 01:27:15 +0000 UTC Use 0xFE opacity for sheld in maximized state. This is a workaround. Using fully opaque color somehow causes the content clipping on the arc content window. It'll be investigated separately. Bug: 901538 Test: manual. Change-Id: Ifee1ccdeb3e877008f33ef62ba1dd5024bb4b196 Reviewed-on: https://chromium-review.googlesource.com/c/1324393 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606185}(cherry picked from commit bc8967075ab8cf77627863845dc4a3af22b47f88) Reviewed-on: https://chromium-review.googlesource.com/c/1328181 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#598} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4157336f64a534595ce1b4ef6fe90c400a648df3 commit 4157336f64a534595ce1b4ef6fe90c400a648df3 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Nov 09 07:10:15 2018 Make sure that workspace on android side is within chrome's work area. Bug: 901538 Test: manually tested with squid. Change-Id: I06cf91e0bbcc5281f2f4caf65dc84b0f1833087c Reviewed-on: https://chromium-review.googlesource.com/c/1328161 Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606756} [modify] https://crrev.com/4157336f64a534595ce1b4ef6fe90c400a648df3/components/exo/wayland/server.cc
,
Nov 9
geohsu@, I also need to merge the CL #12. Could you please approve?
,
Nov 9
,
Nov 9
New merge request approved for ChromeOS M71
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f274e513dcf95332414bb44997668626d4e9c91 commit 0f274e513dcf95332414bb44997668626d4e9c91 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Nov 09 21:39:58 2018 Make sure that workspace on android side is within chrome's work area. Bug: 901538 Test: manually tested with squid. Change-Id: I06cf91e0bbcc5281f2f4caf65dc84b0f1833087c Reviewed-on: https://chromium-review.googlesource.com/c/1328161 Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606756}(cherry picked from commit 4157336f64a534595ce1b4ef6fe90c400a648df3) Reviewed-on: https://chromium-review.googlesource.com/c/1330331 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#621} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/0f274e513dcf95332414bb44997668626d4e9c91/components/exo/wayland/server.cc
,
Nov 9
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f274e513dcf95332414bb44997668626d4e9c91 Commit: 0f274e513dcf95332414bb44997668626d4e9c91 Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-09 21:39:58 +0000 UTC Make sure that workspace on android side is within chrome's work area. Bug: 901538 Test: manually tested with squid. Change-Id: I06cf91e0bbcc5281f2f4caf65dc84b0f1833087c Reviewed-on: https://chromium-review.googlesource.com/c/1328161 Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606756}(cherry picked from commit 4157336f64a534595ce1b4ef6fe90c400a648df3) Reviewed-on: https://chromium-review.googlesource.com/c/1330331 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#621} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by osh...@chromium.org
, Nov 3