New issue
Advanced search Search tips

Issue 901515 link

Starred by 1 user
Status: Assigned
Owner: ----
Cc:
w...@chromium.org
asvitk...@chromium.org
EstimatedDays: ----
NextAction: 2019-11-01
OS: Windows
Pri: 3
Type: Task



Sign in to add a comment

Ongoing experiment: Albatross: Enable DCHECKs for some %age of Chrome Canary users

Project Member Reported by w...@chromium.org, Nov 2 
In issue 782393 we introduced the DCheckCanary_DCheckIsFatal Finch experiment, used to opt-in a %age of Chrome Canary users to run with DCHECKs enabled.  Paired with a specially instrumented build pushed to a fraction of Canary users, this provides early warning of real-world regressions in invariants expressed via DCHECKs, e.g. checks on correct API call ordering, correct threading, etc.

This is a tracking bug for the experiment, which is intended to be run indefinitely.

The experiment is currently maintained by wez@; bug is not assigned to him, since it does not actually track active work.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a177e5d458de0cab24e18d6030f9534af96ad3e2

commit a177e5d458de0cab24e18d6030f9534af96ad3e2
Author: Wez <wez@chromium.org>
Date: Wed Nov 28 00:41:09 2018

Add flag-metadata for dcheck-is-fatal.

Mark dcheck-is-fatal as a special never-expiring flag, since it is used
with special DCHECK-enabled builds to explicitly opt-in (or out) of
crashing when a check fails.

Bug: 901515
Change-Id: I153082352eaaa048db9d4070f802b4ce1ab8c38a
Reviewed-on: https://chromium-review.googlesource.com/c/1351732
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611464}
[modify] https://crrev.com/a177e5d458de0cab24e18d6030f9534af96ad3e2/chrome/browser/flag-metadata.json
►

Sign in to add a comment