New issue
Advanced search Search tips

Issue 901502 link

Starred by 1 user
Status: Assigned
Owner:
lukasza@chromium.org
Cc:
pfeldman@chromium.org
wittman@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: http/tests/devtools/oopif/oopif-storage.js

Blocking:
issue 870761



Sign in to add a comment

http/tests/devtools/oopif/oopif-storage.js is flaky

Project Member Reported by Findit, Nov 2 

Flaky test: http/tests/devtools/oopif/oopif-storage.js
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/6278
Test output log: https://chromium-swarm.appspot.com/task?id=40eec28a8ad7f110
Culprit (96.8% confidence): r604955
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKfAWNocm9taXVtLm1hYy9XZWJLaXQgTWFjMTAuMTMgKHJldGluYSkvNjI3OC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIEFUSSBHUFUgb24gTWFjIFJldGluYSBvbiBNYWMtMTAuMTMuNi9hSFIwY0M5MFpYTjBjeTlrWlhaMGIyOXNjeTl2YjNCcFppOXZiM0JwWmkxemRHOXlZV2RsTG1wegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20http/tests/devtools/oopif/oopif-storage.js&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKfAWNocm9taXVtLm1hYy9XZWJLaXQgTWFjMTAuMTMgKHJldGluYSkvNjI3OC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIEFUSSBHUFUgb24gTWFjIFJldGluYSBvbiBNYWMtMTAuMTMuNi9hSFIwY0M5MFpYTjBjeTlrWlhaMGIyOXNjeTl2YjNCcFppOXZiM0JwWmkxemRHOXlZV2RsTG1wegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).

Comment 1 by wittman@chromium.org, Nov 2

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Owner: masonfreed@chromium.org
Status: Assigned (was: Untriaged)
Culprit was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1315942

Assigning to masonfreed@ to address before relanding.

Comment 2 by lukasza@chromium.org, Nov 5

Blocking: 870761

Comment 3 by lukasza@chromium.org, Nov 5 

It seems that the problem is simply caused by different order of items returned via sessionStorageTree.childrenListElement.deepTextContent():

From: https://test-results.appspot.com/data/layout_results/WebKit_Mac10_13__retina_/6278/webkit_layout_tests/layout-test-results/results.html :

 Local Storage:
-http://127.0.0.1:8000http://devtools.oopif.test:8000http://devtools.oopif.test:8000http://127.0.0.1:8000
+http://127.0.0.1:8000http://devtools.oopif.test:8000http://127.0.0.1:8000http://devtools.oopif.test:8000
 Session Storage:
-http://127.0.0.1:8000http://devtools.oopif.test:8000http://devtools.oopif.test:8000http://127.0.0.1:8000
+http://127.0.0.1:8000http://devtools.oopif.test:8000http://127.0.0.1:8000http://devtools.oopif.test:8000

Comment 4 by lukasza@chromium.org, Nov 5

Cc: pfeldman@chromium.org
+pfeldman@ who AFAICT added Node.prototype.deepTextContent in https://codereview.chromium.org/596323002/patch/140001/150014

Comment 5 by lukasza@chromium.org, Nov 5 

+wittman@ - I am also not sure which CL should be blamed here.  FWIW, it seems that both r604955 (in #c0) and r605004 (in #c1) got blamed?

Comment 6 by lukasza@chromium.org, Nov 5

Cc: wittman@chromium.org
+wittman@ for real this time :-)

Comment 7 by wittman@chromium.org, Nov 5 

I would trust FindIt. :) There were multiple failures in this target at the same time and I think I assigned this based on the wrong culprit.

Comment 8 by masonfreed@chromium.org, Nov 6

Owner: lukasza@chromium.org
Sorry I just noticed this bug, but I am kind of confused. The FindIt analysis looks pretty convincing, and points pretty squarely to 604955. Mine was a rebaseline and was reverted fairly immediately. I'm going to reassign this to lukasza@ for now - but let me know if you disagree!
►

Sign in to add a comment