Issue metadata
Sign in to add a comment
|
UpdateClient XML serializer is broken when disabled reasons are present. |
||||||||||||||||||||||
Issue description
When extensions contain "disabled" reasons, the XML serialization of a request is malformed.
For example, the request is serialized as:
<app appid="jebgalgnebhfojomionfpkfelancnnkf" version="0.9" brand="TEST" enabled="0"<disabled reason="0"/>
^
this is a bug
The change was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1278476
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05d610bfffc6a715c4d4aece4461032af065402d commit 05d610bfffc6a715c4d4aece4461032af065402d Author: Sorin Jianu <sorin@chromium.org> Date: Sat Nov 03 00:58:56 2018 Fix UpdateClient XML serialization when <disabled> reasons are present. The buggy code serializes the <disabled> tag before closing the <app> tag, like this: <app appid=...version="0.9" brand="TEST" enabled="0"<disabled reason="0"/> Bug: 901497 Change-Id: I2106ee35e99dd9c7fa66baab0c0efdc4942cab05 Reviewed-on: https://chromium-review.googlesource.com/c/1316441 Reviewed-by: Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605113} [modify] https://crrev.com/05d610bfffc6a715c4d4aece4461032af065402d/components/update_client/protocol_serializer_xml.cc
,
Dec 17
,
Dec 17
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sorin@chromium.org
, Nov 2