New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 901489 link

Starred by 1 user
Status: Assigned
Owner:
█ nasko@chromium.org
Out until 24 Jan
Cc:
wittman@google.com
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

document-domain-canonicalizes crashes on Mac 10.13 (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 2 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of wittman@google.com

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6118

11:14:12.468 12573   [12599:775:1102/111412.268696:FATAL:security_origin.cc(531)] Check failed: host == DecodeURLEscapeSequences(host) ("sub%2C.subdomain.example.test" vs. "sub,.subdomain.example.test")
11:14:12.468 12573   0   libbase.dylib                       0x000000010776a2de base::debug::StackTrace::StackTrace(unsigned long) + 174
11:14:12.468 12573   1   libbase.dylib                       0x000000010776a39d base::debug::StackTrace::StackTrace(unsigned long) + 29
11:14:12.468 12573   2   libbase.dylib                       0x000000010733ccda base::debug::StackTrace::StackTrace() + 26
11:14:12.468 12573   3   libbase.dylib                       0x00000001073aaf5d logging::LogMessage::~LogMessage() + 461
11:14:12.469 12573   4   libbase.dylib                       0x00000001073a8af5 logging::LogMessage::~LogMessage() + 21
11:14:12.469 12573   5   libblink_platform.dylib             0x00000001384263bc blink::SecurityOrigin::Create(WTF::String const&, WTF::String const&, unsigned short) + 268
11:14:12.469 12573   6   libblink_platform.dylib             0x0000000138425fda blink::SecurityOrigin::CreateFromUrlOrigin(url::Origin const&) + 1690
11:14:12.469 12573   7   libblink_platform.dylib             0x0000000137e7f73b blink::WebSecurityOrigin::WebSecurityOrigin(url::Origin const&) + 59
11:14:12.469 12573   8   libblink_platform.dylib             0x0000000137e7f7cd blink::WebSecurityOrigin::WebSecurityOrigin(url::Origin const&) + 29
11:14:12.469 12573   9   libcontent.dylib                    0x000000010f21106e content::RenderFrameProxy::OnDidUpdateOrigin(url::Origin const&, bool) + 62
11:14:12.469 12573   10  libcontent.dylib                    0x000000010f21d048 void base::DispatchToMethodImpl<content::RenderFrameProxy*, void (content::RenderFrameProxy::*)(url::Origin const&, bool), std::__1::tuple<url::Origin, bool>, 0ul, 1ul>(content::RenderFrameProxy* const&, void (content::RenderFrameProxy::*)(url::Origin const&, bool), std::__1::tuple<url::Origin, bool>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 200
11:14:12.469 12573   11  libcontent.dylib                    0x000000010f21cf78 void base::DispatchToMethod<content::RenderFrameProxy*, void (content::RenderFrameProxy::*)(url::Origin const&, bool), std::__1::tuple<url::Origin, bool> >(content::RenderFrameProxy* const&, void (content::RenderFrameProxy::*)(url::Origin const&, bool), std::__1::tuple<url::Origin, bool>&&) + 104
11:14:12.469 12573   12  libcontent.dylib                    0x000000010f21cee2 void IPC::DispatchToMethod<content::RenderFrameProxy, void (content::RenderFrameProxy::*)(url::Origin const&, bool), void, std::__1::tuple<url::Origin, bool> >(content::RenderFrameProxy*, void (content::RenderFrameProxy::*)(url::Origin const&, bool), void*, std::__1::tuple<url::Origin, bool>&&) + 114
11:14:12.469 12573   13  libcontent.dylib                    0x000000010f210fb6 bool IPC::MessageT<FrameMsg_DidUpdateOrigin_Meta, std::__1::tuple<url::Origin, bool>, void>::Dispatch<content::RenderFrameProxy, content::RenderFrameProxy, void, void (content::RenderFrameProxy::*)(url::Origin const&, bool)>(IPC::Message const*, content::RenderFrameProxy*, content::RenderFrameProxy*, void*, void (content::RenderFrameProxy::*)(url::Origin const&, bool)) + 582
11:14:12.469 12573   14  libcontent.dylib                    0x000000010f20d193 content::RenderFrameProxy::OnMessageReceived(IPC::Message const&) + 2707
11:14:12.469 12573   15  libipc.dylib                        0x00000001071bb538 IPC::MessageRouter::RouteMessage(IPC::Message const&) + 88
11:14:12.469 12573   16  libcontent.dylib                    0x000000010a699628 content::ChildThreadImpl::ChildThreadMessageRouter::RouteMessage(IPC::Message const&) + 40
11:14:12.469 12573   17  libipc.dylib                        0x00000001071bb4c8 IPC::MessageRouter::OnMessageReceived(IPC::Message const&) + 88
11:14:12.469 12573   18  libcontent.dylib                    0x000000010a6a25c0 content::ChildThreadImpl::OnMessageReceived(IPC::Message const&) + 96
11:14:12.469 12573   19  libipc.dylib                        0x0000000107164655 IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) + 149
11:14:12.469 12573   20  libipc.dylib                        0x000000010716b71f void base::internal::FunctorTraits<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), void>::Invoke<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message const&>(void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&&&, IPC::Message const&&&) + 143
11:14:12.469 12573   21  libipc.dylib                        0x000000010716b61f void base::internal::InvokeHelper<false, void>::MakeItSo<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&, IPC::Message const&>(void (IPC::ChannelProxy::Context::* const&&&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context> const&&&, IPC::Message const&&&) + 95
11:14:12.469 12573   22  libipc.dylib                        0x000000010716b5ad void base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::RunImpl<void (IPC::ChannelProxy::Context::* const&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message> const&, 0ul, 1ul>(void (IPC::ChannelProxy::Context::* const&&&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 125
11:14:12.469 12573   23  libipc.dylib                        0x000000010716b4ac base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::Run(base::internal::BindStateBase*) + 44
11:14:12.469 12573   24  libbase.dylib                       0x00000001072e133c base::OnceCallback<void ()>::Run() && + 92
11:14:12.469 12573   25  libbase.dylib                       0x000000010733ea09 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033
11:14:12.470 12573   26  libbase.dylib                       0x00000001075de5f1 base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) + 1601
11:14:12.470 12573   27  libbase.dylib                       0x00000001075e1771 void base::internal::FunctorTraits<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), void>::Invoke<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&>(void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&&&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&&&) + 145
11:14:12.470 12573   28  libbase.dylib                       0x00000001075e1675 void base::internal::InvokeHelper<true, void>::MakeItSo<void (base::sequence_manager::internal::ThreadControllerImpl::* const&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&>(void (base::sequence_manager::internal::ThreadControllerImpl::* const&&&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl> const&&&, base::sequence_manager::internal::ThreadControllerImpl::WorkType const&&&) + 117
11:14:12.470 12573   29  libbase.dylib                       0x00000001075e15ed void base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType>, void ()>::RunImpl<void (base::sequence_manager::internal::ThreadControllerImpl::* const&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), std::__1::tuple<base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType> const&, 0ul, 1ul>(void (base::sequence_manager::internal::ThreadControllerImpl::* const&&&)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), std::__1::tuple<base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType> const&&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 125
11:14:12.470 12573   30  libbase.dylib                       0x00000001075e14ec base::internal::Invoker<base::internal::BindState<void (base::sequence_manager::internal::ThreadControllerImpl::*)(base::sequence_manager::internal::ThreadControllerImpl::WorkType), base::WeakPtr<base::sequence_manager::internal::ThreadControllerImpl>, base::sequence_manager::internal::ThreadControllerImpl::WorkType>, void ()>::Run(base::internal::BindStateBase*) + 44
11:14:12.470 12573   31  libbase.dylib                       0x00000001072e133c base::OnceCallback<void ()>::Run() && + 92
11:14:12.470 12573   32  libbase.dylib                       0x000000010733ea09 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033
11:14:12.470 12573   33  libbase.dylib                       0x00000001073fb00f base::MessageLoop::RunTask(base::PendingTask*) + 1199
11:14:12.470 12573   34  libbase.dylib                       0x00000001073fb50f base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 95
11:14:12.470 12573   35  libbase.dylib                       0x00000001073fbb6a base::MessageLoop::DoWork() + 490
11:14:12.470 12573   36  libbase.dylib                       0x00000001074075a2 base::MessagePumpCFRunLoopBase::RunWork() + 98
11:14:12.470 12573   37  libbase.dylib                       0x000000010740752c ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
11:14:12.470 12573   38  libbase.dylib                       0x00000001073b0daa base::mac::CallWithEHFrame(void () block_pointer) + 10
11:14:12.470 12573   39  libbase.dylib                       0x0000000107406405 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101
11:14:12.470 12573   40  CoreFoundation                      0x00007fff4084cd81 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
11:14:12.470 12573   41  CoreFoundation                      0x00007fff4090465c __CFRunLoopDoSource0 + 108
11:14:12.470 12573   42  CoreFoundation                      0x00007fff4082fd30 __CFRunLoopDoSources0 + 208
11:14:12.470 12573   43  CoreFoundation                      0x00007fff4082f1ad __CFRunLoopRun + 1293
11:14:12.470 12573   44  CoreFoundation                      0x00007fff4082ea07 CFRunLoopRunSpecific + 487
11:14:12.470 12573   45  Foundation                          0x00007fff42945f26 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
11:14:12.470 12573   46  libbase.dylib                       0x0000000107408099 base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 185
11:14:12.470 12573   47  libbase.dylib                       0x0000000107405a45 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 101
11:14:12.470 12573   48  libbase.dylib                       0x00000001073fa68c base::MessageLoop::Run(bool) + 556
11:14:12.470 12573   49  libbase.dylib                       0x00000001074ebd8e base::RunLoop::Run() + 606
11:14:12.470 12573   50  libcontent.dylib                    0x000000010f2dd82d content::RendererMain(content::MainFunctionParams const&) + 3837
11:14:12.471 12573   51  libcontent.dylib                    0x000000010f680052 content::RunOtherNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 482
11:14:12.471 12573   52  libcontent.dylib                    0x000000010f68370a content::ContentMainRunnerImpl::Run(bool) + 5418
11:14:12.471 12573   53  libcontent.dylib                    0x000000010f679adc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 76
11:14:12.471 12573   54  libembedder.dylib                   0x0000000156e6cef7 service_manager::Main(service_manager::MainParams const&) + 3751
11:14:12.471 12573   55  libcontent.dylib                    0x000000010f67fcc9 content::ContentMain(content::ContentMainParams const&) + 89
11:14:12.471 12573   56  Content Shell Framework             0x0000000101aa46d6 ContentMain + 1094
11:14:12.471 12573   57  Content Shell Helper                0x0000000101803d82 main + 1538
11:14:12.471 12573   58  libdyld.dylib                       0x00007fff686eb015 start + 1
11:14:12.471 12573   59  ???                                 0x0000000000000020 0x0 + 32
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44ef0985bfb071388cf33d288a8a83c02aac8101

commit 44ef0985bfb071388cf33d288a8a83c02aac8101
Author: Mike Wittman <wittman@chromium.org>
Date: Sat Nov 03 02:59:54 2018

Update update-registration-with-type and document-domain-canonicalizes test expectations

TBR=nhiroki@chromium.org, nasko@chromium.org

Bug: 901489,  901317 
Change-Id: Ifeb2e93e78c8eb0b7db73a5c66cd7a10bd15b0e8
Reviewed-on: https://chromium-review.googlesource.com/c/1316549
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605140}
[modify] https://crrev.com/44ef0985bfb071388cf33d288a8a83c02aac8101/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by wittman@chromium.org, Nov 3

Cc: dcheng@chromium.org
Labels: -Pri-2 Pri-1
Owner: nasko@chromium.org
Status: Assigned (was: Available)
It's not clear what caused this to start failing, so assigning to nasko who touched related code recently.

Also raising to Pri-1 since this failure may have security implications.

Comment 3 by hbos@chromium.org, Nov 5

Labels: -Sheriff-Chromium
Removing sheriff label since the test expecations have been updated.

Comment 4 by nasko@chromium.org, Dec 5

Components: Blink>Internals
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e40da55dafbc6b2bbde36538781274d99ee7bf9a

commit e40da55dafbc6b2bbde36538781274d99ee7bf9a
Author: Nasko Oskov <nasko@chromium.org>
Date: Tue Jan 15 00:41:50 2019

Remove test expectations for document-domain-canonicalizes.html.

TBR=yoav@yoav.ws

Bug: 901489
Change-Id: I14cf9236fdf8f677a94ec494094618ec01ce27ee
Reviewed-on: https://chromium-review.googlesource.com/c/1406207
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622658}
[modify] https://crrev.com/e40da55dafbc6b2bbde36538781274d99ee7bf9a/third_party/blink/web_tests/TestExpectations

Comment 6 by battre@chromium.org, Jan 15 

This is failing again with the same errors. Reverting the last CL.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d7573ef5d624922d8433bf5f506f85e1a1f1f63

commit 7d7573ef5d624922d8433bf5f506f85e1a1f1f63
Author: Dominic Battré <battre@chromium.org>
Date: Tue Jan 15 12:34:35 2019

Revert "Remove test expectations for document-domain-canonicalizes.html."

This reverts commit e40da55dafbc6b2bbde36538781274d99ee7bf9a.

Reason for revert: Failing again crbug.com/901489

Original change's description:
> Remove test expectations for document-domain-canonicalizes.html.
> 
> TBR=yoav@yoav.ws
> 
> Bug: 901489
> Change-Id: I14cf9236fdf8f677a94ec494094618ec01ce27ee
> Reviewed-on: https://chromium-review.googlesource.com/c/1406207
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Commit-Queue: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622658}

TBR=nasko@chromium.org,yoav@yoav.ws

Change-Id: Icf5f0f876a404b1579015d882b507951aea1c398
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 901489
Reviewed-on: https://chromium-review.googlesource.com/c/1411924
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622828}
[modify] https://crrev.com/7d7573ef5d624922d8433bf5f506f85e1a1f1f63/third_party/blink/web_tests/TestExpectations
►

Sign in to add a comment