New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901469 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Disable LPM for Logitech Rally

Project Member Reported by kdgw...@google.com, Nov 2

Issue description

Summarizing b/115756398 - Logitech Rally Camera ([046D:0881], [046D:0888], [046D:0889]) LPM should be disabled in the quirks.c file as a workaround to b/65034294

Similar to crbug/758293.

We are specifically interested in fixing on teemo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0b7372553f6dfee567972b062a32d7e3edda75e0

commit 0b7372553f6dfee567972b062a32d7e3edda75e0
Author: Kyle Williams <kdgwill@google.com>
Date: Wed Nov 07 14:34:50 2018

CHROMIUM: USB: quirks: add NO_LPM quirk for Logitech Rally Camera

Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of a Logitech Rally and Atrus device causes
'not enough bandwidth for new device state'error

This patch creates quirk entries for the Logitech Rally Camera
indicating LPM should remain disabled for the device.

Note: This is an established workaround for an ongoing partner bug with
the specific intent of getting the Rally Camera working on Teemo
@see b/65034294

TEST=While using Logitech Rally camera w/ Atrus on Teemo and Buddy

BUG= chromium:901469 , b:115756398

Change-Id: I67d9943cd5d66604b8bbee89f2ce240db8f7cb04
Signed-off-by: Kyle Williams <kdgwill@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1297535
Commit-Ready: Kyle Williams <kdgwill@chromium.org>
Tested-by: Kyle Williams <kdgwill@chromium.org>
Tested-by: Andrew Wong <wongan@google.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Andrew Wong <wongan@google.com>

[modify] https://crrev.com/0b7372553f6dfee567972b062a32d7e3edda75e0/drivers/usb/core/quirks.c

Cc: ziegs@chromium.org sjohnston@google.com jhillyerd@google.com mnilsson@chromium.org jtho@chromium.org
Labels: -Pri-3 Merge-Request-71 Pri-1
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 7

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Description: Show this description
Labels: OS-Chrome
Labels: -Merge-Review-71 Merge-Approved-71
Approved for ChromeOS M71
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7

Labels: merge-merged-release-R71-11151.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1c38ea17cf5d9449d4ed127116ff135e23e0659a

commit 1c38ea17cf5d9449d4ed127116ff135e23e0659a
Author: Kyle Williams <kdgwill@google.com>
Date: Wed Nov 07 22:40:04 2018

CHROMIUM: USB: quirks: add NO_LPM quirk for Logitech Rally Camera

Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of a Logitech Rally and Atrus device causes
'not enough bandwidth for new device state'error

This patch creates quirk entries for the Logitech Rally Camera
indicating LPM should remain disabled for the device.

Note: This is an established workaround for an ongoing partner bug with
the specific intent of getting the Rally Camera working on Teemo
@see b/65034294

TEST=While using Logitech Rally camera w/ Atrus on Teemo and Buddy

BUG= chromium:901469 , b:115756398

Change-Id: I67d9943cd5d66604b8bbee89f2ce240db8f7cb04
Signed-off-by: Kyle Williams <kdgwill@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1297535
Commit-Ready: Kyle Williams <kdgwill@chromium.org>
Tested-by: Kyle Williams <kdgwill@chromium.org>
Tested-by: Andrew Wong <wongan@google.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Andrew Wong <wongan@google.com>
(cherry picked from commit 0b7372553f6dfee567972b062a32d7e3edda75e0)
Reviewed-on: https://chromium-review.googlesource.com/c/1324610
Reviewed-by: Kyle Williams <kdgwill@chromium.org>
Reviewed-by: Geo Hsu <geohsu@chromium.org>
Commit-Queue: Kyle Williams <kdgwill@chromium.org>
Trybot-Ready: Kyle Williams <kdgwill@chromium.org>

[modify] https://crrev.com/1c38ea17cf5d9449d4ed127116ff135e23e0659a/drivers/usb/core/quirks.c

Labels: Target-71 Merge-Merged
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 12

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 16

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Labels: -Merge-Approved-71

Sign in to add a comment