New issue
Advanced search Search tips

Issue 901464 link

Starred by 1 user
Status: Fixed
Owner:
dullweber@chromium.org
Closed: Nov 16
Cc:
sabineb@chromium.org
msramek@chromium.org
msarda@chromium.org
dullweber@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add user action for impression/clicks on footer of CBD dialogue

Project Member Reported by ew...@chromium.org, Nov 2 
It would be useful to be able to calculate CTR for the action buttons in the various footers in the CBD dialogue ("sign out" for syncing users, "sign in" for sync-opted-in-but-signed-out users, "enter passphrase" for custom passphrase users, etc.)

Right now, we don't instrument those buttons at all.

Comment 1 by dullweber@chromium.org, Nov 8

Status: Started (was: Assigned)
I created a CL to record the following actions: https://crrev.com/c/1326496

ClearBrowsingData_Sync_SignIn
ClearBrowsingData_Sync_Pause
ClearBrowsingData_Sync_NavigateToPassphrase
ClearBrowsingData_Sync_NavigateToError

As a baseline, ClearBrowsingData_DialogCreated already records how often the dialog is shown.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9508190e73d32c22f93da8e4d57b3ca12d21b34

commit e9508190e73d32c22f93da8e4d57b3ca12d21b34
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Nov 16 09:54:43 2018

Record sync related user-actions from ClearBrowsingData

This adds a few user actions to record how users interact with the new
sync ui in ClearBrowsingData.

Bug:  901464 
Change-Id: Ib8291ff0d8d81f133eb0a5c707ef864afa46309a
Reviewed-on: https://chromium-review.googlesource.com/c/1326496
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608715}
[modify] https://crrev.com/e9508190e73d32c22f93da8e4d57b3ca12d21b34/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/e9508190e73d32c22f93da8e4d57b3ca12d21b34/tools/metrics/actions/actions.xml

Comment 3 by dullweber@chromium.org, Nov 16

Status: Fixed (was: Started)
►

Sign in to add a comment