"ProfileChooser_SignInAgainDisplayed" recorded after turnong on |
|||
Issue descriptionChrome Version: 72 Canary OS: Mac OS X What steps will reproduce the problem? (1) Sign into gmail.com with a Google Account (2) Open the user menu by clicking your avatar in the toolbar (3) Click "Turn on sync" What is the expected result? (4) Signin_Signin_FromAvatarBubbleSignin and Signin_SigninWithDefault_FromAvatarBubbleSignin user actions are recorded What happens instead? (4) Signin_Signin_FromAvatarBubbleSignin and Signin_SigninWithDefault_FromAvatarBubbleSignin user actions are recorded, but so is ProfileChooser_SignInAgainDisplayed, which doesn't make sense, because the user never saw a "Sign in again" button in the user menu (which is shown only when the user has sync paused and opens the user menu). Assigning to Vasilii to investigate, since he implemented these metrics :) Thanks!
,
Nov 6
CC+ Thomas as he also worked on the DICE user menu.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00a0e731b795e35a50ae475ec5ba2a838211ed74 commit 00a0e731b795e35a50ae475ec5ba2a838211ed74 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Nov 08 11:18:27 2018 Don't update the profile chooser if it's to be closed. Unnecessary update skews the metrics. Typical flow before the CL is - The profile chooser shown. - User clicks something. - The profile chooser is being hidden. - Some state changes and updates still existing bubble. Bug: 901449 Change-Id: Iee9b5c7757aad2f0d9c7149a1e26b33e6e954716 Reviewed-on: https://chromium-review.googlesource.com/c/1320172 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606412} [modify] https://crrev.com/00a0e731b795e35a50ae475ec5ba2a838211ed74/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/00a0e731b795e35a50ae475ec5ba2a838211ed74/chrome/browser/ui/views/profiles/profile_chooser_view.h [modify] https://crrev.com/00a0e731b795e35a50ae475ec5ba2a838211ed74/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
,
Nov 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vasi...@chromium.org
, Nov 5