New issue
Advanced search Search tips

Issue 901449 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

"ProfileChooser_SignInAgainDisplayed" recorded after turnong on

Project Member Reported by ew...@chromium.org, Nov 2

Issue description

Chrome Version: 72 Canary
OS: Mac OS X

What steps will reproduce the problem?
(1) Sign into gmail.com with a Google Account
(2) Open the user menu by clicking your avatar in the toolbar
(3) Click "Turn on sync"

What is the expected result?
(4) Signin_Signin_FromAvatarBubbleSignin and Signin_SigninWithDefault_FromAvatarBubbleSignin user actions are recorded

What happens instead?
(4) Signin_Signin_FromAvatarBubbleSignin and Signin_SigninWithDefault_FromAvatarBubbleSignin user actions are recorded, but so is ProfileChooser_SignInAgainDisplayed, which doesn't make sense, because the user never saw a "Sign in again" button in the user menu (which is shown only when the user has sync paused and opens the user menu). Assigning to Vasilii to investigate, since he implemented these metrics :) Thanks!
 
Screen Shot 2018-11-02 at 1.18.36 PM.png
26.8 KB View Download
#2 0x55bf0d7c4909 ProfileChooserView::CreateDiceSyncErrorView()
#3 0x55bf0d7c2741 ProfileChooserView::CreateSyncErrorViewIfNeeded()
#4 0x55bf0d7ba467 ProfileChooserView::CreateProfileChooserView()
#5 0x55bf0d7b8e1b ProfileChooserView::ShowView()
#6 0x55bf0d7b8a72 ProfileChooserView::OnAvatarMenuChanged()
#7 0x55bf0d7c93dc AvatarMenu::Update()
#8 0x55bf0d7c9519 AvatarMenu::OnProfileAuthInfoChanged()
#9 0x55bf09578677 ProfileInfoCache::SetAuthInfoOfProfileAtIndex()
#10 0x55bf0951ec6c ProfileAttributesEntry::SetAuthInfo()
#11 0x55bf0963237e ChromeSigninClient::OnSignedIn()
#12 0x55bf0a702543 SigninManager::OnSignedIn()
#13 0x55bf0a7029b2 SigninManager::OnExternalSigninCompleted()
#14 0x55bf0d6ba44a DiceTurnSyncOnHelper::SigninAndShowSyncConfirmationUI()
#15 0x55bf0d6b9f1b DiceTurnSyncOnHelper::OnRegisteredForPolicy()
#16 0x55bf06b5eb2f _ZN4base8internal13FunctorTraitsIMN18OAuth2TokenService11RequestImplEFvRK22GoogleServiceAuthErrorRKN25OAuth2AccessTokenConsumer13TokenResponseEEvE6InvokeISC_RKNS_7WeakPtrIS3_EEJS6_SA_EEEvT_OT0_DpOT1_
#17 0x55bf06b5ea85 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN18OAuth2TokenService11RequestImplEFvRK22GoogleServiceAuthErrorRKN25OAuth2AccessTokenConsumer13TokenResponseEERKNS_7WeakPtrIS5_EEJS8_SC_EEEvOT_OT0_DpOT1_
#18 0x55bf07ebdaa0 _ZN4base8internal7InvokerINS0_9BindStateIMN11google_apis19UrlFetchRequestBaseEFvRK4GURLRKN7network20ResourceResponseHeadEEJNS_7WeakPtrIS4_EEEEEFvS7_SB_EE7RunImplISD_NSt3__15tupleIJSF_EEEJLm0EEEEvOT_OT0_NSK_16integer_sequenceImJXspT1_EEEES7_SB_
#19 0x55bf0915d3a4 _ZN4base8internal7InvokerINS0_9BindStateIM18InstallableManagerFvRK4GURLRKN5blink8ManifestEEJNS_7WeakPtrIS3_EEEEEFvS6_SA_EE3RunEPNS0_13BindStateBaseES6_SA_
#20 0x55bf078f11d0 _ZNKR4base17RepeatingCallbackIFvRKNSt3__16vectorIN10extensions3api21DocumentScanInterface18ScannerDescriptionENS1_9allocatorIS6_EEEERKNS1_12basic_stringIcNS1_11char_traitsIcEENS7_IcEEEEEE3RunESB_SI_
#21 0x55bf09a1c3d4 policy::UserPolicySigninService::RegisterForPolicyWithAccountId()
#22 0x55bf0d6b8b0d DiceTurnSyncOnHelper::TurnSyncOnWithProfileMode()
#23 0x55bf0d6b851f DiceTurnSyncOnHelper::DiceTurnSyncOnHelper()
#24 0x55bf0d6b901f DiceTurnSyncOnHelper::DiceTurnSyncOnHelper()
#25 0x55bf09910342 (anonymous namespace)::CreateDiceTurnSyncOnHelper()
#26 0x55bf09913d57 _ZN4base8internal13FunctorTraitsIPFvP7ProfileP7BrowserN14signin_metrics11AccessPointENS6_11PromoActionENS6_6ReasonERKNSt3__112basic_stringIcNSA_11char_traitsIcEENSA_9allocatorIcEEEEN20DiceTurnSyncOnHelper17SigninAbortedModeEEvE6InvokeISM_JS3_S5_S7_S8_S9_SI_SK_EEEvOT_DpOT0_
#27 0x55bf09913c85 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvP7ProfileP7BrowserN14signin_metrics11AccessPointENS8_11PromoActionENS8_6ReasonERKNSt3__112basic_stringIcNSC_11char_traitsIcEENSC_9allocatorIcEEEEN20DiceTurnSyncOnHelper17SigninAbortedModeEEJS5_S7_S9_SA_SB_SK_SM_EEEvOT_DpOT0_
#28 0x55bf09913bcb _ZN4base8internal7InvokerINS0_9BindStateIPFvP7ProfileP7BrowserN14signin_metrics11AccessPointENS7_11PromoActionENS7_6ReasonERKNSt3__112basic_stringIcNSB_11char_traitsIcEENSB_9allocatorIcEEEEN20DiceTurnSyncOnHelper17SigninAbortedModeEEJEEESM_E7RunImplISN_NSB_5tupleIJEEEJEEEvOT_OT0_NSB_16integer_sequenceImJXspT1_EEEEOS4_OS6_OS8_OS9_OSA_SJ_OSL_
#29 0x55bf09913b01 _ZN4base8internal7InvokerINS0_9BindStateIPFvP7ProfileP7BrowserN14signin_metrics11AccessPointENS7_11PromoActionENS7_6ReasonERKNSt3__112basic_stringIcNSB_11char_traitsIcEENSB_9allocatorIcEEEEN20DiceTurnSyncOnHelper17SigninAbortedModeEEJEEESM_E7RunOnceEPNS0_13BindStateBaseES4_S6_S8_S9_SA_SJ_SL_
#30 0x55bf09912cf7 _ZNO4base12OnceCallbackIFvP7ProfileP7BrowserN14signin_metrics11AccessPointENS5_11PromoActionENS5_6ReasonERKNSt3__112basic_stringIcNS9_11char_traitsIcEENS9_9allocatorIcEEEEN20DiceTurnSyncOnHelper17SigninAbortedModeEEE3RunES2_S4_S6_S7_S8_SH_SJ_
#31 0x55bf099102b2 signin_ui_util::internal::EnableSyncFromPromo()
#32 0x55bf0990faa0 signin_ui_util::EnableSyncFromPromo()
#33 0x55bf0d7bc3b7 ProfileChooserView::ButtonPressed()

This is the stack trace. When user clicks "Sign in" the menu is synchronously updated and the action is recorded. Of course the view is destroyed immediately so the user doesn't see the new version.
Cc: tangltom@chromium.org
CC+ Thomas as he also worked on the DICE user menu.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00a0e731b795e35a50ae475ec5ba2a838211ed74

commit 00a0e731b795e35a50ae475ec5ba2a838211ed74
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Nov 08 11:18:27 2018

Don't update the profile chooser if it's to be closed.

Unnecessary update skews the metrics. Typical flow before the CL is
- The profile chooser shown.
- User clicks something.
- The profile chooser is being hidden.
- Some state changes and updates still existing bubble.

Bug:  901449 
Change-Id: Iee9b5c7757aad2f0d9c7149a1e26b33e6e954716
Reviewed-on: https://chromium-review.googlesource.com/c/1320172
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606412}
[modify] https://crrev.com/00a0e731b795e35a50ae475ec5ba2a838211ed74/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/00a0e731b795e35a50ae475ec5ba2a838211ed74/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/00a0e731b795e35a50ae475ec5ba2a838211ed74/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment