New issue
Advanced search Search tips

Issue 901409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 904951

Blocking:
issue 850004



Sign in to add a comment

[css-logical] Logical values should compute as-is and resolve with respect to the containing block

Project Member Reported by obru...@igalia.com, Nov 2

Issue description

The CSS Logical spec was clarified after I implemented logical values in  issue 850004 .

https://drafts.csswg.org/css-logical/#float-clear says
> Computed value: as specified
> The mapping on these properties uses the writing mode of the element’s containing block.

Currently they compute to the corresponding physical value, and the mapping uses the writing mode of the element itself.
 
Blockedon: 904951
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421

commit 65766f28741f0bfbbdf1d0b327b72fbc4f4f4421
Author: Oriol Brufau <obrufau@igalia.com>
Date: Fri Nov 16 11:32:48 2018

[css-logical] Fix logical values according to the spec

Spec: https://drafts.csswg.org/css-logical/#directional-keywords

Currently logical values compute to the corresponding physical value,
and the mapping is with respect to the element itself. This patch
makes them compute as specified and changes the mapping to be with
respect to the containing block.

BUG= 901409 

TEST=external/wpt/css/css-logical/logical-values-float-clear.html
TEST=external/wpt/css/css-logical/logical-values-float-clear-reftest.html
TEST=external/wpt/css/css-logical/logical-values-resize.html
TEST=webexposed/nonstable-css-properties.html

Change-Id: Ie0acaacde813c5343ec3bb8de712c4af03639475
Reviewed-on: https://chromium-review.googlesource.com/c/1315989
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608730}
[add] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-values-float-clear-reftest.html
[delete] https://crrev.com/5938614858237f4ff1cf9f54c4e26eb4979b9ff2/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/logical-values-resize-expected.txt
[add] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/reference/logical-values-float-clear-reftest-ref.html
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/WebKit/LayoutTests/external/wpt/css/css-logical/resources/test-logical-values.js
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/WebKit/LayoutTests/webexposed/nonstable-css-properties-expected.txt
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/css/css_primitive_value_mappings.h
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/css/css_properties.json5
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/css/properties/longhands/clear_custom.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/css/properties/longhands/float_custom.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/css/properties/longhands/resize_custom.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/BUILD.gn
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/floating_objects.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/floating_objects.h
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/layout_block_flow_line.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/line/DEPS
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/line/breaking_context_inline_headers.h
[add] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/logical_values.cc
[add] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/logical_values.h
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/ng_floats_utils.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/ng_floats_utils.h
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/ng/ng_unpositioned_float.h
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/layout/text_autosizer.cc
[modify] https://crrev.com/65766f28741f0bfbbdf1d0b327b72fbc4f4f4421/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc

Status: Fixed (was: Started)

Sign in to add a comment