Add UKM metrics for mixed content |
||||||||||
Issue descriptionBefore starting the mixed content autoupgrade experiment we want to detect any sites that have a large amount of mixed content and reach out to them about the experiment (and the opt-out procedure). This requires getting UKM metrics about mixed content.
,
Nov 7
,
Nov 7
It could be done for iOS, by adding the metrics to the relevant spots where the checks are done (e.g. https://cs.chromium.org/chromium/src/ios/web/net/request_tracker_impl.mm?rcl=d0c866c2ccc89e8a16350583b90f6080e44efde0&l=325 for subresources). However the rest of the autoupgrade experiment is non-iOS only (since it happens in Blink), I'd say as a blocker for the experiment this can be non-iOS, and we can add it to iOS if we find it useful as a permanent metric.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce commit e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce Author: Carlos IL <carlosil@chromium.org> Date: Thu Nov 08 00:10:58 2018 Added metrics for mixed content events Added UKM and UMA metrics that trigger when a site displays or runs mixed content. Bug: 901403 Change-Id: I855682e2c0999a859070e89907838bcc133f8673 Reviewed-on: https://chromium-review.googlesource.com/c/1319189 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#606237} [modify] https://crrev.com/e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce/content/browser/ssl/ssl_manager.cc [modify] https://crrev.com/e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce/tools/metrics/histograms/enums.xml [modify] https://crrev.com/e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce/tools/metrics/ukm/ukm.xml
,
Nov 8
Requesting merge approval since we'd like to get mixed content metrics from 71, unblocking the rest of the experiment for 72. The above CL doesn't change any behavior, just adds a UKM/UMA metric that gets logged every time the browser displays or runs mixed content
,
Nov 8
The CL is already in Canary (72.0.3605.0)
,
Nov 8
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8
Changing back to bug and re adding Merge Request tag to get into the attention of milestone owners. Would it be acceptable to merge this one in? This is a set of prerequisite metrics, and waiting until 72 to get those in would delay the actual experiment until 73.
,
Nov 8
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 8
Approving merge to M71 branch 3578 based on comments #5, #6 and #8. Please merge ASAP. Thank you.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b6140c343905ca3a532a850080d2eb0f22a7904 commit 1b6140c343905ca3a532a850080d2eb0f22a7904 Author: Carlos IL <carlosil@chromium.org> Date: Thu Nov 08 19:26:34 2018 Added metrics for mixed content events Added UKM and UMA metrics that trigger when a site displays or runs mixed content. Bug: 901403 Change-Id: I855682e2c0999a859070e89907838bcc133f8673 Reviewed-on: https://chromium-review.googlesource.com/c/1319189 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606237}(cherry picked from commit e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce) Reviewed-on: https://chromium-review.googlesource.com/c/1327542 Reviewed-by: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#583} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/1b6140c343905ca3a532a850080d2eb0f22a7904/content/browser/ssl/ssl_manager.cc [modify] https://crrev.com/1b6140c343905ca3a532a850080d2eb0f22a7904/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1b6140c343905ca3a532a850080d2eb0f22a7904/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/1b6140c343905ca3a532a850080d2eb0f22a7904/tools/metrics/ukm/ukm.xml
,
Nov 8
Thanks!
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b6140c343905ca3a532a850080d2eb0f22a7904 Commit: 1b6140c343905ca3a532a850080d2eb0f22a7904 Author: carlosil@chromium.org Commiter: carlosil@chromium.org Date: 2018-11-08 19:26:34 +0000 UTC Added metrics for mixed content events Added UKM and UMA metrics that trigger when a site displays or runs mixed content. Bug: 901403 Change-Id: I855682e2c0999a859070e89907838bcc133f8673 Reviewed-on: https://chromium-review.googlesource.com/c/1319189 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#606237}(cherry picked from commit e0c9eec9f74e4cd9cca5ef8c3980b6bc677c3cce) Reviewed-on: https://chromium-review.googlesource.com/c/1327542 Reviewed-by: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#583} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by palmer@chromium.org
, Nov 7