New issue
Advanced search Search tips

Issue 901350 link

Starred by 2 users
Status: Fixed
Owner:
knollr@chromium.org
Closed: Nov 14
Cc:
nyerramilli@chromium.org
tetsui@chromium.org
rbasuvula@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

First Notification is not shown to the user

Project Member Reported by knollr@chromium.org, Nov 2 
Chrome Version: 72.0.3600.0
OS: Linux

What steps will reproduce the problem?
(1) Open up Chrome
(2) Disable native notifications (chrome://flags#enable-native-notifications)
(3) Open any webpage
(4) Call Notification.requestPermission() in the Console and Accept
(5) Call new Notification('Test1') in the Console
(6) Call new Notification('Test2') in the Console again

What is the expected result?
Expect to see a Notification after (5) and another one after (6).

What happens instead?
No Notification after (5) and two Notifications after (6).

This happens because PopupsOnlyUiController and MessagePopupCollection both register as an observer of MessageCenter, but in the wrong order. After the second Notification is shown, everything works as expected.

Comment 1 by knollr@chromium.org, Nov 5

Components: UI>Notifications
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b60074a6e4d55c4cebce38b845cf7adb015b8029

commit b60074a6e4d55c4cebce38b845cf7adb015b8029
Author: Richard Knoll <knollr@chromium.org>
Date: Mon Nov 05 14:54:10 2018

fix: fix first shown notification

This makes sure that the observer registrations are in the correct
order.

Bug:  901350 
Change-Id: I57f45c7e605984928546d85386bdfb8e19f67352
Reviewed-on: https://chromium-review.googlesource.com/c/1314597
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605330}
[modify] https://crrev.com/b60074a6e4d55c4cebce38b845cf7adb015b8029/chrome/browser/BUILD.gn
[modify] https://crrev.com/b60074a6e4d55c4cebce38b845cf7adb015b8029/chrome/browser/notifications/notification_ui_manager_browsertest.cc
[modify] https://crrev.com/b60074a6e4d55c4cebce38b845cf7adb015b8029/chrome/browser/notifications/notification_ui_manager_impl.cc
[modify] https://crrev.com/b60074a6e4d55c4cebce38b845cf7adb015b8029/chrome/browser/notifications/popups_only_ui_controller.cc
[modify] https://crrev.com/b60074a6e4d55c4cebce38b845cf7adb015b8029/chrome/browser/notifications/popups_only_ui_controller.h
[modify] https://crrev.com/b60074a6e4d55c4cebce38b845cf7adb015b8029/chrome/browser/ui/views/message_center/popups_only_ui_delegate_unittest.cc

Comment 3 by knollr@chromium.org, Nov 5

Cc: nyerramilli@chromium.org tetsui@chromium.org rbasuvula@chromium.org
 Issue 901732  has been merged into this issue.

Comment 4 by robliao@google.com, Nov 8

Labels: Hotlist-DesktopUIConsider

Comment 5 by robliao@chromium.org, Nov 8

Labels: Group-Notifications

Comment 6 by robliao@google.com, Nov 8

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged

Comment 7 by jmukthavaram@chromium.org, Nov 14

Status: WontFix (was: Started)
Closing the bug as a part of UI mass triage. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue.

Comment 8 by jmukthavaram@chromium.org, Nov 14

Labels: Hotlist-DesktopUIChecked

Comment 9 by knollr@chromium.org, Nov 14

Status: Fixed (was: WontFix)
It's actually already fixed, just forgot to update the issue.
It's available in 72.0.3608.4 for Linux.
►

Sign in to add a comment