power.typical_10_mobile Rotating earth failing |
||||||
Issue descriptionFirst failure: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android-go-perf/1350 It looks like the browser crashed. There is a crash dump, but does not appear to be symbolized. Full logs: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8931015158825258768/+/power.typical_10_mobile_78b6b8e3-1b59-4ce6-8f15-ab08c5d21e70 Will try kicking off a pinpoint job ...
,
Nov 2
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/10ba1241e40000 NavigationPredictor: Skip anchor elements that belong to an ad frame by tbansal@chromium.org https://chromium.googlesource.com/chromium/src/+/36713b504ce73cffb00f386ff1e33c4c3fe03f34 Failure rate: 0 → 1 (+1) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Nov 2
CL being reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1315208 tbansal to reproduce the failing test you could try running src$ ./tools/perf/run_benchmark --browser android-chromium power.typical_10_mobile --story-filter earth
,
Nov 2
Marking as fixed since the CL has already been reverted. I will try to reland the CL with appropriate fix.
,
Nov 5
This same test is failing again, error message includes: I 1.702s Main Stack Trace: I 1.702s Main RELADDR FUNCTION FILE:LINE I 1.702s Main v------> blink::LocalFrame::IsAdSubframe() const /b/build/slave/arm-builder-rel/build/src/third_party/blink/renderer/core/frame/local_frame.h:381:38 I 1.702s Main v------> blink::(anonymous namespace)::IsInAdFrame(blink::HTMLAnchorElement const&) /b/build/slave/arm-builder-rel/build/src/third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc:23:0 I 1.702s Main 0270a9d6 blink::AnchorElementMetricsSender::AddAnchorElement(blink::HTMLAnchorElement&) /b/build/slave/arm-builder-rel/build/src/third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc:81:0 Could this also be related to your recent work?
,
Nov 5
I will take a look today or latest by tomorrow. FWIW, I had loaded that page manually and did not see any problems with the CL. Is it the only page that's failing?
,
Nov 5
Yes, it's only and consistently that page.
,
Nov 5
thank you. I will definitely take a look later today or latest by tomorrow.
,
Nov 5
Is it possible to know which revision this crash happened on? As per c#5 above, the stack trace has IsInAdFrame() method. However, this method got removed in the CL referenced in c#3 above. That revert happened ~3 days ago. Also, see https://cs.chromium.org/search/?q=IsInAdFrame&sq=package:chromium&type=cs So, it seems that the bot is still stuck on a revision older than 3 days? I poked around in the stdout from c#6 above, but could not find the revision number. I am closing this since I do not think the crash should happen on ToT. If it does, please feel free to reopen. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 2