New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901311 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in network::mdns_helper::CreateResolutionResponse

Project Member Reported by ClusterFuzz, Nov 2

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4824943274229760

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  network::mdns_helper::CreateResolutionResponse
  network::MdnsResponder::CreateNameForAddress
  network::mojom::MdnsResponderStubDispatch::AcceptWithResponder
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=604802:604803

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4824943274229760

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 2

Labels: Test-Predator-Auto-Owner
Owner: qingsi@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c2213d5d6e8702362b2798ee2c84a125a1312f46 (Add the mDNS responder service.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: mpdenton@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10dcbdfa1ff36b0a092e6eee4611fddc13d894d

commit f10dcbdfa1ff36b0a092e6eee4611fddc13d894d
Author: Qingsi Wang <qingsi@google.com>
Date: Thu Jan 17 19:46:56 2019

Add error handling in CreateNameForAddress of the MdnsResponder service.

This adds error handling of invalid inputs to the implementation of
the above service API in addition to DCHECKs.

Bug:  901311 
Change-Id: I93bb43b79bcbfc78e8564567dc4ddf29751a7375
Reviewed-on: https://chromium-review.googlesource.com/c/1377502
Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Qingsi Wang <qingsi@google.com>
Cr-Commit-Position: refs/heads/master@{#623806}
[modify] https://crrev.com/f10dcbdfa1ff36b0a092e6eee4611fddc13d894d/services/network/mdns_responder.cc
[modify] https://crrev.com/f10dcbdfa1ff36b0a092e6eee4611fddc13d894d/services/network/mdns_responder_unittest.cc

Project Member

Comment 4 by ClusterFuzz, Jan 18 (4 days ago)

ClusterFuzz has detected this issue as fixed in range 623805:623806.

Detailed report: https://clusterfuzz.com/testcase?key=4824943274229760

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  network::mdns_helper::CreateResolutionResponse
  network::MdnsResponder::CreateNameForAddress
  network::mojom::MdnsResponderStubDispatch::AcceptWithResponder
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=604802:604803
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=623805:623806

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4824943274229760

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jan 18 (4 days ago)

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4824943274229760 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment