New issue
Advanced search Search tips

Issue 901304 link

Starred by 1 user
Status: Verified
Owner:
machenb...@chromium.org
Closed: Nov 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 830557



Sign in to add a comment

Factor out presubmit recipe for V8 CI

Project Member Reported by machenb...@chromium.org, Nov 2 
Presubmit is different to all other V8 testing. Currently it makes test configurations more complicated to keep presubmit around as a normal test. There's also technical dept around it requiring and downloading builds without needing them.

This proposes to add a new simple recipe that just runs v8/tools/v8_presubmit.py in CI.

This will unblock the following:
- Legacy download_build method won't be needed anymore in V8 recipe.
- No need to disable swarming on presubmit builder
- Several simplifications in testing.py
- Presubmit will run faster as it doesn't need to be triggered anymore by the linux builder

Comment 1 by machenb...@chromium.org, Nov 2

Components: Infra>Client>V8
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/99bf148649ed164fae8c9fae059adb5da6dfdf44

commit 99bf148649ed164fae8c9fae059adb5da6dfdf44
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 14:42:56 2018

[V8] Add v8 presubmit recipe

This adds a simple presubmit recipe, which will allow to remove the
presubmit portions from the standard V8 recipe.

R=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: I5d344b15fe47479b76e50eb709cd09fb1dcab425
Reviewed-on: https://chromium-review.googlesource.com/c/1314549
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/99bf148649ed164fae8c9fae059adb5da6dfdf44/scripts/slave/README.recipes.md
[add] https://crrev.com/99bf148649ed164fae8c9fae059adb5da6dfdf44/scripts/slave/recipes/v8/presubmit.expected/basic.json
[add] https://crrev.com/99bf148649ed164fae8c9fae059adb5da6dfdf44/scripts/slave/recipes/v8/presubmit.py
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/30f821f05b43362311d5a8ae8cd3c91c6aeeac4e

commit 30f821f05b43362311d5a8ae8cd3c91c6aeeac4e
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 14:45:29 2018

Add next-gen presubmit builders

NOTRY=true
R=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: If9fedd7d1735ebace5d0b6f46845020f87959255
Reviewed-on: https://chromium-review.googlesource.com/c/1314571
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/30f821f05b43362311d5a8ae8cd3c91c6aeeac4e/cr-buildbucket.cfg
[modify] https://crrev.com/30f821f05b43362311d5a8ae8cd3c91c6aeeac4e/luci-milo.cfg
[modify] https://crrev.com/30f821f05b43362311d5a8ae8cd3c91c6aeeac4e/luci-scheduler.cfg
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4b856bb4d6f4620417879932b975ba61e566968e

commit 4b856bb4d6f4620417879932b975ba61e566968e
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 14:54:30 2018

Remove legacy presubmit builder

NOTRY=true
R=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: Ie6c22f12f1c0ff8884234e1d84c0a7e1de2f91c5
Reviewed-on: https://chromium-review.googlesource.com/c/1314572
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/4b856bb4d6f4620417879932b975ba61e566968e/cr-buildbucket.cfg
[modify] https://crrev.com/4b856bb4d6f4620417879932b975ba61e566968e/luci-milo.cfg
[modify] https://crrev.com/4b856bb4d6f4620417879932b975ba61e566968e/luci-scheduler.cfg
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c1215df6cdc306d90e2929a8767ca43d33e01786

commit c1215df6cdc306d90e2929a8767ca43d33e01786
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 14:59:37 2018

[test] Remove legacy presubmit test configs

NOTRY=true
R=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: I343fa257f21afb4eff103b1bc52ba2bcb59fecc8
Reviewed-on: https://chromium-review.googlesource.com/c/1314573
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57215}
[modify] https://crrev.com/c1215df6cdc306d90e2929a8767ca43d33e01786/infra/testing/builders.pyl
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/6f446e5c540975cecb746c094a50aaa8a0b2d893

commit 6f446e5c540975cecb746c094a50aaa8a0b2d893
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 15:00:26 2018
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2

Labels: merge-merged-7.0
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/70ddaf9ecd67935ad6e56b9708a4062ca797d3f1

commit 70ddaf9ecd67935ad6e56b9708a4062ca797d3f1
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 15:06:34 2018

[test] Remove legacy presubmit test configs on 7.0 branch

NOPRESUBMIT=true
NOTRY=true
TBR=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: I150b2cb66dc2ed0c452f14e6b555987efc46b313
Reviewed-on: https://chromium-review.googlesource.com/c/1314576
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#71}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424}
[modify] https://crrev.com/70ddaf9ecd67935ad6e56b9708a4062ca797d3f1/infra/testing/builders.pyl
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2

Labels: merge-merged-7.1
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/52c0cbbfd00d84bf9c94ed81e2b9aac5c4e10152

commit 52c0cbbfd00d84bf9c94ed81e2b9aac5c4e10152
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Nov 02 15:07:37 2018

[test] Remove legacy presubmit test configs on 7.1 branch

NOPRESUBMIT=true
NOTRY=true
TBR=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: Ia7861b90f7fc4017743400fdcfba4d7ba20d0640
Reviewed-on: https://chromium-review.googlesource.com/c/1314575
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.1@{#30}
Cr-Branched-From: f70aaa8ab2e8815505a6145c745e50d8328cd28c-refs/heads/7.1.302@{#1}
Cr-Branched-From: 1dbcc78efa17a9047f7e923958087ef9eec43066-refs/heads/master@{#56462}
[modify] https://crrev.com/52c0cbbfd00d84bf9c94ed81e2b9aac5c4e10152/infra/testing/builders.pyl
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/4e315b380aaf169531143e8138a393ab0f2f7f94

commit 4e315b380aaf169531143e8138a393ab0f2f7f94
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 06 11:44:12 2018
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1c3df310dba0a680bad6ab63bd5134718ee47632

commit 1c3df310dba0a680bad6ab63bd5134718ee47632
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 06 11:58:25 2018

[V8] Remove legacy presubmit support

Depends on https://crrev.com/i/708888.

R=sergiyb@chromium.org

Bug:  chromium:901304 
Change-Id: Ic7213d488b582f79e6ad3b368ca7d417441cbb68
Reviewed-on: https://chromium-review.googlesource.com/c/1314551
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder_trigger_on_luci.json
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipe_modules/v8/api.py
[delete] https://crrev.com/da5229d3e68e7be0447f5701d91c4a1c24143512/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_presubmit.json
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/README.recipes.md
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipe_modules/v8/builders.py
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipe_modules/v8/testing.py
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipes/v8.py
[modify] https://crrev.com/1c3df310dba0a680bad6ab63bd5134718ee47632/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder_experimental.json
[delete] https://crrev.com/da5229d3e68e7be0447f5701d91c4a1c24143512/scripts/slave/recipes/v8.expected/full_client_v8_V8_Foobar_tester_experimental.json

Comment 11 by machenb...@chromium.org, Nov 6

Status: Verified (was: Started)
►

Sign in to add a comment