New issue
Advanced search Search tips

Issue 901290 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : 'ENTER SIM PIN' Text field is still seen enabled or active even after clicking on 'ENTER' button in Cellular connected page

Project Member Reported by mmanchala@chromium.org, Nov 2

Issue description

Chrome Version: 72.0.3593.0/11219.0.0 dev-channel Falco,Jeery and Celes
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page
(3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> enter pin and now click on 'ENTER' button ('ENTER' button is still seen disabled)
(4)Observe still Text field is seen active i.e. able to clear or add
(Please refer Video)

Expected:  Text field should be inactive after clicking on 'Enter'
Actual: Instead Text field is still seen enabled even after clicking on 'ENTER' button

This is Non-regression Issue seen from M-62

 
Actual_Textfield.mp4
12.2 MB View Download
Cc: tbarzic@chromium.org
Owner: tonydeluna@chromium.org
Status: Assigned (was: Untriaged)
Tony, this might be a good starter bug.
I can't reproduce using my local linux build.

I'll wait for tomorrow to get a sim and test on device.
Spoke with tbarzic in person and showed me how to reproduce bug, I am now able to reproduce it and I'm working on a fix.  
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9eaf95ce60014b3ea7bc9fe6207c730b6ad804e

commit e9eaf95ce60014b3ea7bc9fe6207c730b6ad804e
Author: Tony de Luna <tonydeluna@chromium.org>
Date: Wed Nov 07 23:24:18 2018

SIM lock: Disable password fields while updating.

It might take some seconds between users submit pin update and
operation completes. In the meantime users shouldn't be able to
modify the PIN input fields.


Bug:  901290 
Change-Id: I21aa06288d3f0aaf00db8dae72715a8a4e94d85d
Reviewed-on: https://chromium-review.googlesource.com/c/1323903
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606201}
[modify] https://crrev.com/e9eaf95ce60014b3ea7bc9fe6207c730b6ad804e/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html

Status: Fixed (was: Assigned)

Sign in to add a comment