Regression:Overlapping of Favicon is seen while dragging One tab on another.
Reported by
shruti.j...@etouch.net,
Nov 2
|
|||||||
Issue descriptionChrome Version:72.0.3599.0 (Official Build) 82c7cfa9c7fd09ada624b966c15a6784d3760132-refs/branch-heads/3599@{#1}(32/64 bit) OS: Win(7,8,8.1,10) ,Mac(10.13.1 , 10.13.6 , 10.14.1) and Linux(14.04 LTS) Steps to reproduce: 1. Launch chrome , open NTP. 2. Navigate to google.com and Drag NTP on google.com NTP. 3. Observe the favicons. Actual Result : Overlapping of Favicon is seen while dragging One tab on another. Expected Result : No such overlapping of favicon should be seen while dragging One tab on another. This is a regression issue, broken in 'M72', and below is bisect info: Good Build:72.0.3596.0 Bad Build:72.0.3597.0 Change Log: https://chromium.googlesource.com/chromium/src/+log/72.0.3596.0..72.0.3597.0?pretty=fuller&n=10000 Suspecting: r604356 ? pbos: @Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. 1. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error. 2. Unable to perform Chromium bisect as build is not available. 3. Hence providing suspect manually. Thank You!
,
Nov 8
,
Nov 8
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ceb3938769495604041e416b21f7c2a3989539a0 commit ceb3938769495604041e416b21f7c2a3989539a0 Author: Peter Boström <pbos@chromium.org> Date: Fri Nov 09 00:33:04 2018 Remove TabIcon from a layer after animations end Removing TabIcon from a layer used to happen after SetData marks a tab as no longer loading. With the new tab-icon animation we extend the animation period for 200ms past that. This is a speculative fix for the referenced bug that I've been unable to reproduce locally. Bug: chromium:901277 Change-Id: I81c5e5af56fddc90ca210b027a681cd2309d2742 Reviewed-on: https://chromium-review.googlesource.com/c/1327231 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#606654} [modify] https://crrev.com/ceb3938769495604041e416b21f7c2a3989539a0/chrome/browser/ui/views/tabs/tab_icon.cc [modify] https://crrev.com/ceb3938769495604041e416b21f7c2a3989539a0/chrome/browser/ui/views/tabs/tab_icon.h
,
Nov 9
I believe this should've fixed it. I can't reproduce it locally however, can you check and try to repro in the next Canary? I'll mark it as Fixed meanwhile as I don't see how this would be painting above the tab if we make sure to not have the tab icon as a separate layer.
,
Nov 9
Update : Retested above issue on OS: Win(7,8,8.1,10) ,Mac(10.13.1 , 10.13.6 , 10.14.1) and Linux(14.04 LTS) using latest Canary #72.0.3606.0 and issue is fixed.No overlapping of favicon is seen while dragging One tab on another. Kindly review the attached screen-cast. Thank you
,
Nov 9
Thanks!
,
Nov 16
** Mass UI Triage ** |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by robliao@google.com
, Nov 8