New issue
Advanced search Search tips

Issue 901255 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ISO-2022-JP encoder: 373 code points are not encoded per WHATWG spec

Project Member Reported by js...@chromium.org, Nov 2

Issue description

https://www.w3.org/International/tests/repo/run?base=encoding&batch=encoding-dbl-byte&test=legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form.html 

Chrome has 373 code points mis-encoded for ISO-2022-JP. 


The encoding of 373 code point into ISO-2022-JP failed because they're
mapped to SJIS code points for which there's no JIS 208 mapping.
Using JIS X 208 table in EUC-JP solves this issue.


 
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/834113aab5c1e5647690f93d9ae25f724095dd40

commit 834113aab5c1e5647690f93d9ae25f724095dd40
Author: Jungshik Shin <jshin@chromium.org>
Date: Sun Nov 04 05:21:16 2018

Make ISO-2022-JP converter compliant to the WHATWG encoding spec

The encoding of 373 code point into ISO-2022-JP failed because they're
mapped to SJIS code points for which there's no JIS 208 mapping.
Using JIS X 208 table in EUC-JP solves this issue.

Upstream bug: https://unicode-org.atlassian.net/browse/ICU-20251

Bug:  901255 
Test: https://www.w3.org/International/tests/repo/run?base=encoding&batch=encoding-dbl-byte&test=legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form.html
Change-Id: I3237fa1269a3ae2e89b22e246aaf2ae43fd56c7d
Reviewed-on: https://chromium-review.googlesource.com/c/1314052
Reviewed-by: Joshua Bell <jsbell@chromium.org>

[modify] https://crrev.com/834113aab5c1e5647690f93d9ae25f724095dd40/README.chromium
[add] https://crrev.com/834113aab5c1e5647690f93d9ae25f724095dd40/patches/iso2022jp.patch
[modify] https://crrev.com/834113aab5c1e5647690f93d9ae25f724095dd40/source/common/ucnv2022.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d54018cc4739d4e6bf098a1eaa45fb0234587f

commit e3d54018cc4739d4e6bf098a1eaa45fb0234587f
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Nov 06 06:08:56 2018

Roll ICU to 834113

It has two changes:

https://chromium.googlesource.com/chromium/deps/icu.git/+log/42d5027..834113

One is to cherry-pick an integer overflow fix. The other is to fix
ISO-2022-JP encoding.

Now that 373 code points are encoded as expected. Rebaseline the test results
(delete them because all the code points in those files pass).

Bug:  901255 ,  900059 
Test: See  bug 900059 
Test: LayoutTests: external/wpt/encoding/legacy-mb-japanese/iso-2022-jp
Test: https://www.w3.org/International/tests/repo/run?base=encoding&batch=encoding-dbl-byte&test=legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form.html
Change-Id: I474ac74c270b77c46f786b28d04494fadb753694
Reviewed-on: https://chromium-review.googlesource.com/c/1317129
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605609}
[modify] https://crrev.com/e3d54018cc4739d4e6bf098a1eaa45fb0234587f/DEPS
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_1-1000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_1001-2000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_2001-3000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_3001-4000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_4001-5000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_5001-6000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_6001-7000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp_7001-last-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_1-1000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_1001-2000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_2001-3000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_3001-4000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_4001-5000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_5001-6000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_6001-7000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form_7001-last-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_1-1000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_1001-2000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_2001-3000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_3001-4000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_4001-5000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_5001-6000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_6001-7000-expected.txt
[delete] https://crrev.com/2cc1550c36085cb1afa75b0f5b159af15f8d997d/third_party/WebKit/LayoutTests/external/wpt/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href_7001-last-expected.txt

Status: Fixed (was: Started)

Sign in to add a comment