Issue metadata
Sign in to add a comment
|
PictureInPictureWindowControllerBrowserTest.EnterPictureInPictureThenFullscreen is flaky |
||||||||||||||||||||||||
Issue descriptionFlaky test: PictureInPictureWindowControllerBrowserTest.EnterPictureInPictureThenFullscreen Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29904 Test output log: https://chromium-swarm.appspot.com/task?id=40e9b3fc076a6c10 Culprit (70.0% confidence): r604494 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy7QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK2AWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5OTA0L2Jyb3dzZXJfdGVzdHMvVUdsamRIVnlaVWx1VUdsamRIVnlaVmRwYm1SdmQwTnZiblJ5YjJ4c1pYSkNjbTkzYzJWeVZHVnpkQzVGYm5SbGNsQnBZM1IxY21WSmJsQnBZM1IxY21WVWFHVnVSblZzYkhOamNtVmxiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PictureInPictureWindowControllerBrowserTest.EnterPictureInPictureThenFullscreen&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy7QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK2AWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5OTA0L2Jyb3dzZXJfdGVzdHMvVUdsamRIVnlaVWx1VUdsamRIVnlaVmRwYm1SdmQwTnZiblJ5YjJ4c1pYSkNjbTkzYzJWeVZHVnpkQzVGYm5SbGNsQnBZM1IxY21WSmJsQnBZM1IxY21WVWFHVnVSblZzYkhOamNtVmxiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 2
yoshiki@, do you think your CL could be related?
,
Nov 2
From https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PictureInPictureWindowControllerBrowserTest.EnterPictureInPictureThenFullscreen this is flaky only on linux-chromeos-dbg and Linux Chromium OS ASan LSan Tests (1)
,
Nov 2
I will disable the test on ChromeOS.
,
Nov 2
Disabling the test in https://chromium-review.googlesource.com/c/chromium/src/+/1315207.
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4de8bc5d850d2995233b3c0b80b1a04ca8ad560c commit 4de8bc5d850d2995233b3c0b80b1a04ca8ad560c Author: vitaliii <vitaliii@chromium.org> Date: Fri Nov 02 15:22:10 2018 Disable EnterPictureInPictureThenFullscreen test on ChromeOS. Because flaky. PictureInPictureWindowControllerBrowserTest.EnterPictureInPictureThenFullscreen TBR=mlamouri@chromium.org Bug: 901235 Change-Id: Iab53371efe290a16b475c0a002c0561b184f8b08 Reviewed-on: https://chromium-review.googlesource.com/c/1315207 Reviewed-by: vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604925} [modify] https://crrev.com/4de8bc5d850d2995233b3c0b80b1a04ca8ad560c/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
,
Nov 2
This started to flake after the CL you landed yoshiki@. Can you PTAL?
,
Nov 2
,
Nov 6
Working on a fix: https://chromium-review.googlesource.com/c/chromium/src/+/1316986
,
Nov 6
This is still flaking, the test was disabled on all platform except for ChromeOS, I'll make a CL to disable it only on ChromeOS.
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5382853eda08bd7bfbd791ee67f2b122ffb3f11 commit c5382853eda08bd7bfbd791ee67f2b122ffb3f11 Author: Henrik Boström <hbos@chromium.org> Date: Tue Nov 06 13:11:22 2018 Disable EnterPictureInPictureThenFullscreen test on ChromeOS. This was supposed to have been disabled on ChromeOS in https://chromium-review.googlesource.com/c/chromium/src/+/1315207 but the CL disabled it on all platforms *except* for ChromeOS. Removing the "!" from "!defined(OS_CHROMEOS)" because this has kept flaking, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8738 TBR=mlamouri@chromium.org, vitaliii@chromium.org NOTRY=True Bug: 901235 Change-Id: I78ece1196efee61aa9c5fd66fd166290e3d8fbd6 Reviewed-on: https://chromium-review.googlesource.com/c/1319713 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605663} [modify] https://crrev.com/c5382853eda08bd7bfbd791ee67f2b122ffb3f11/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
,
Nov 6
Removing sheriff label.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12ee465b66458244a1dfd04e87b6f3b87dd543e9 commit 12ee465b66458244a1dfd04e87b6f3b87dd543e9 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Nov 08 01:33:01 2018 Update the mask bounds when window bounds is changed Recently the chrome pip windows have WindowStateType::PIP and behaves as pip windows. Pip windows moves with animation but the mask bounds was not synced with these animation. As the result, the test was flaky (see the bug). This CL adds the observer of window bounds and make it sure that the layer bounds is synced with the window bounds. Bug: 901235 Test: Ran PictureInPictureWindowControllerBrowserTest. EnterPictureInPictureThenFullscreen 10 times and observed no error. Change-Id: Ide03ab1465170ccaf35af08377d3dd1df0cf7ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1316986 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606273} [modify] https://crrev.com/12ee465b66458244a1dfd04e87b6f3b87dd543e9/ash/wm/window_state.cc [modify] https://crrev.com/12ee465b66458244a1dfd04e87b6f3b87dd543e9/ash/wm/window_state.h [modify] https://crrev.com/12ee465b66458244a1dfd04e87b6f3b87dd543e9/ash/wm/window_state_unittest.cc
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03bbf595d43923c1a72a1806317137ffac968aac commit 03bbf595d43923c1a72a1806317137ffac968aac Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Nov 08 08:27:49 2018 Re-enable EnterPictureInPictureThenFullscreen test on ChromeOS. This CL is almost reverts of the following CL: crrev.com/c/1315207 This test has been disabled on Chrome OS because of flakiness: crbug.com/901235 . The flakiness is fixed by the recent change (crrev.com/c/1316986) so that this CL re-enable it. TBR=mlamouri@chromium.org, vitaliii@chromium.org Bug: 901235 Test: trybots pass Change-Id: I1cec695988728ae40bd1f6031135efaf07c760b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325597 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606384} [modify] https://crrev.com/03bbf595d43923c1a72a1806317137ffac968aac/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
,
Nov 8
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Nov 2