[Navi] Email module changes |
||||||
Issue description1. Increase height of the each email square to 84 from 80px [Same for Google apps modules] 2. Distance between check mark icon and the edge is 6px (right and top) instead of 10px. [Same for Google apps modules] 3. Having Gmail pre-selected 4. Having selected module text font medium weight (currently its regular) [Same for Google apps modules]
,
Nov 13
CL for selection issue: https://crrev.com/c/1332696
,
Nov 13
Screenshots for medium font weight CL: https://crrev.com/c/1332715
,
Nov 13
Height of squares is already 84px and distance from corners for the check box is already 10px
,
Nov 13
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e711c42cb6af258aa72b76a9660148cc78ed819 commit 1e711c42cb6af258aa72b76a9660148cc78ed819 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Nov 13 21:30:03 2018 Navi: Medium font weight for selected option in email and apps. Screenshots in bug. Bug: 901210 Change-Id: I7a8cc24801ac66fd2d9e01a4bae03824811dd19d Reviewed-on: https://chromium-review.googlesource.com/c/1332715 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#607742} [modify] https://crrev.com/1e711c42cb6af258aa72b76a9660148cc78ed819/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b954e406f3886d861a064f9b78c5068e54d57d8 commit 1b954e406f3886d861a064f9b78c5068e54d57d8 Author: Hector Carmona <hcarmona@chromium.org> Date: Wed Nov 14 02:10:15 2018 Navi: Pre-select first email provider to have a default. Bug: 901210 , 900377 Change-Id: I928f6cdb1a8251131afbe2e95afe1cbca39703ea Reviewed-on: https://chromium-review.googlesource.com/c/1332696 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607853} [modify] https://crrev.com/1b954e406f3886d861a064f9b78c5068e54d57d8/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js [modify] https://crrev.com/1b954e406f3886d861a064f9b78c5068e54d57d8/chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js [modify] https://crrev.com/1b954e406f3886d861a064f9b78c5068e54d57d8/chrome/test/data/webui/welcome/email_chooser_test.js
,
Nov 14
,
Nov 16
Re-opening bug. Misunderstood: checkbox icon should be 6px from edge. CL coming soon.
,
Nov 16
+Screenshot CL at: https://crrev.com/c/1340872
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e661b8cbbd34ec6cc89a9eb1862ed9ac24ff2bde commit e661b8cbbd34ec6cc89a9eb1862ed9ac24ff2bde Author: Hector Carmona <hcarmona@chromium.org> Date: Sat Nov 17 00:41:29 2018 Navi: Move check icon so it's 6px from edge to match mocks. R=scottchen@chromium.org Bug: 901210 Change-Id: I04a20fe0b81d2ca599865ae664915d0cac060317 Reviewed-on: https://chromium-review.googlesource.com/c/1340872 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#609049} [modify] https://crrev.com/e661b8cbbd34ec6cc89a9eb1862ed9ac24ff2bde/chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
,
Nov 17
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by namratakannan@chromium.org
, Nov 12