Issue 749814  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/406f6ca5c5da3801c37f39df10735f3ad5c5c838

commit 406f6ca5c5da3801c37f39df10735f3ad5c5c838
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Nov 06 07:15:04 2018

DevTools: Show page timing markers on performance panel

The markers are made easily distinguishable by showing a short title
on the timeline by default.

It is put behind an experiment.

BUG= 901165 

Change-Id: I9f6ecbac2ac34d45662840ba55fc32d93ffe1d2e
Reviewed-on: https://chromium-review.googlesource.com/c/1313877
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605621}
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/blink/renderer/devtools/front_end/protocol/InspectorBackend.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/406f6ca5c5da3801c37f39df10735f3ad5c5c838/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a790e866e926688e743e7974b3784f1f882c7c95

commit a790e866e926688e743e7974b3784f1f882c7c95
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Nov 07 02:48:27 2018

DevTools: Show page timing events for main frame only.

BUG= 901165 

Change-Id: Ib29619563845f9f4002d8a01269f74b56ec478c2
Reviewed-on: https://chromium-review.googlesource.com/c/1315993
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605938}
[add] https://crrev.com/a790e866e926688e743e7974b3784f1f882c7c95/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-page-metrics-expected.txt
[add] https://crrev.com/a790e866e926688e743e7974b3784f1f882c7c95/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-page-metrics.js
[modify] https://crrev.com/a790e866e926688e743e7974b3784f1f882c7c95/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js
[modify] https://crrev.com/a790e866e926688e743e7974b3784f1f882c7c95/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/a790e866e926688e743e7974b3784f1f882c7c95/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7e0d6f63de414cf6550407fe669cb5828725218

commit c7e0d6f63de414cf6550407fe669cb5828725218
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Nov 10 02:13:59 2018

DevTools: Stack page timing markers when zoomed out.

Place timing markers next to each other rather that make them overlap.

BUG= 901165 

Change-Id: Iac9d544d6b5e5238767c3451aa9ace9f27126cc9
Reviewed-on: https://chromium-review.googlesource.com/c/1324378
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607078}
[modify] https://crrev.com/c7e0d6f63de414cf6550407fe669cb5828725218/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/c7e0d6f63de414cf6550407fe669cb5828725218/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/c7e0d6f63de414cf6550407fe669cb5828725218/third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/176ebabb28c440f03ffb855f73182ce5bb534526

commit 176ebabb28c440f03ffb855f73182ce5bb534526
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Nov 13 19:14:00 2018

DevTools: Draw page metrics markers with a solid color.

BUG= 901165 

Change-Id: Icbdb38619e2ee76d9fa17621718a7613cf72554c
Reviewed-on: https://chromium-review.googlesource.com/c/1330716
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607694}
[modify] https://crrev.com/176ebabb28c440f03ffb855f73182ce5bb534526/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js

Latest screenshot with metric details.

Deleted: Screenshot from 2018-11-28 16-32-40.png 196 KB

	Screenshot from 2018-11-28 16-32-40.png 196 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/347c3a95955e35a5bbdebdc4e86c6056bb40d615

commit 347c3a95955e35a5bbdebdc4e86c6056bb40d615
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Nov 29 05:16:19 2018

DevTools: Add details text for page performance metrics.

Drive-by: Fix an exception when a selected node is panned offscreen.

BUG= 901165 

Change-Id: I26ae15f3506f89a93e3f91f5aa6715c3f0033b1a
Reviewed-on: https://chromium-review.googlesource.com/c/1352627
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612048}
[modify] https://crrev.com/347c3a95955e35a5bbdebdc4e86c6056bb40d615/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/347c3a95955e35a5bbdebdc4e86c6056bb40d615/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82dab725a234f06178b5c2fd956136256cd466e5

commit 82dab725a234f06178b5c2fd956136256cd466e5
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Nov 30 01:53:56 2018

DevTools: Move page metric events on performance panel out of experiment.

BUG= 901165 

Change-Id: I1788e537ed29bab14558d12372bda59f2bfa8698
Reviewed-on: https://chromium-review.googlesource.com/c/1352850
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612505}
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/main/Main.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-page-metrics.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-search.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4bc8f576d8911ec64de41fe1410e73601a5cbea

commit f4bc8f576d8911ec64de41fe1410e73601a5cbea
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Dec 10 18:38:45 2018

DevTools: Move page metric events on performance panel out of experiment.

BUG= 901165 
TBR=alph@chromium.org

(cherry picked from commit 82dab725a234f06178b5c2fd956136256cd466e5)

Change-Id: I1788e537ed29bab14558d12372bda59f2bfa8698
Reviewed-on: https://chromium-review.googlesource.com/c/1352850
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612505}
Reviewed-on: https://chromium-review.googlesource.com/c/1370364
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#216}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/renderer/devtools/front_end/main/Main.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-page-metrics.js
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt
[modify] https://crrev.com/f4bc8f576d8911ec64de41fe1410e73601a5cbea/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-search.js

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/f4bc8f576d8911ec64de41fe1410e73601a5cbea

Commit: f4bc8f576d8911ec64de41fe1410e73601a5cbea
Author: alph@chromium.org
Commiter: alph@chromium.org
Date: 2018-12-10 18:38:45 +0000 UTC

DevTools: Move page metric events on performance panel out of experiment.

BUG= 901165 
TBR=alph@chromium.org

(cherry picked from commit 82dab725a234f06178b5c2fd956136256cd466e5)

Change-Id: I1788e537ed29bab14558d12372bda59f2bfa8698
Reviewed-on: https://chromium-review.googlesource.com/c/1352850
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612505}
Reviewed-on: https://chromium-review.googlesource.com/c/1370364
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#216}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision f4bc8f576d8911ec64de41fe1410e73601a5cbea was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

How safe is this merge? Why was this merged to M72 without approval?

The merge is safe. It has been approved and merged as part of this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=911837#c4