New issue
Advanced search Search tips

Issue 901127 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

teleportation window avatars are inconsistent

Project Member Reported by est...@chromium.org, Nov 1

Issue description

For hosted app windows, packaged app windows and browser windows, the icons are slightly different sizes. Also for hosted apps (bottom window) the icon seems off center.
 
teleport.png
40.8 KB View Download
screenshot for WIP cl
avatars.png
64.0 KB View Download
Components: UI>Browser
Multi profile is in progress to go away. As such we are possibly not fixing this.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e040344b0a4035689ae37c3c6bade1390593f2c7

commit e040344b0a4035689ae37c3c6bade1390593f2c7
Author: Evan Stade <estade@chromium.org>
Date: Fri Nov 02 19:07:57 2018

Chrome OS: improvements to frame avatar icon.

1. Better (more vertically centered) position for hosted app windows.
2. Correct sizing (29x29 instead of crunching to 24x24) for browser and
   hosted app windows. Packaged apps were already using 29x29.
3. Get rid of outline. GetAvatarImageFor{User,Context} already adds a
   white border.

Bug:  901127 
Change-Id: I5b0fcb1bcd3266c988e1a62c84b4f8455b53df35
Reviewed-on: https://chromium-review.googlesource.com/c/1313746
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605006}
[modify] https://crrev.com/e040344b0a4035689ae37c3c6bade1390593f2c7/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e040344b0a4035689ae37c3c6bade1390593f2c7/chrome/browser/ui/views/profiles/profile_indicator_icon.cc
[modify] https://crrev.com/e040344b0a4035689ae37c3c6bade1390593f2c7/chrome/browser/ui/views/profiles/profile_indicator_icon.h

Status: Fixed (was: Assigned)

Sign in to add a comment