New issue
Advanced search Search tips

Issue 901112 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Nov 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 430155



Sign in to add a comment

Worklet content cannot be properly refreshed

Project Member Reported by yigu@chromium.org, Nov 1 
What steps will reproduce the problem?
(1) Open canary with flag enable-experimental-web-platform-features
(2) Open page https://majido.github.io/houdini-samples/animation-worklet/trip-app/
(3) Open Devtools
(4) Refresh the page

What is the expected result?
Page refreshed. See Stable.

What happens instead?
Somehow the worklet didn't get destroyed / created properly.

Suspecting patch crrev.com/c/1183589. 

dgozman@, PTAL!
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/678cb6046fcb979ee2bed4efc3a3dfecfdc1af22

commit 678cb6046fcb979ee2bed4efc3a3dfecfdc1af22
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Nov 05 20:08:23 2018

[DevTools] Do not pause worklets on start

Worklets running in a separate thread do not have parent_devtools_token,
and so we don't support debugging them. This should probably be fixed.

Meanwhile, we should not also pause them on start - otherwise there is
no way to unpause because nobody is actually debugging them.

Bug:  901112 
Change-Id: I63b59da95a1181ff03886f8fc233aa621726f1f8
Reviewed-on: https://chromium-review.googlesource.com/c/1313837
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605434}
[modify] https://crrev.com/678cb6046fcb979ee2bed4efc3a3dfecfdc1af22/third_party/blink/renderer/core/inspector/worker_inspector_controller.cc
[modify] https://crrev.com/678cb6046fcb979ee2bed4efc3a3dfecfdc1af22/third_party/blink/renderer/core/inspector/worker_inspector_controller.h
[modify] https://crrev.com/678cb6046fcb979ee2bed4efc3a3dfecfdc1af22/third_party/blink/renderer/core/workers/worker_thread.cc

Comment 2 by dgozman@chromium.org, Nov 5

Status: Fixed (was: Assigned)
►

Sign in to add a comment