Merge request for ChromeDriver maximize window bug fix |
||||||||
Issue descriptionRequesting merge of https://chromium-review.googlesource.com/1312990 to m70 and m71 branches. This CL fixes a ChromeDriver/Chrome interaction bug that causes ChromeDriver maximize window command to fail on Mac since m70. This bug is affecting a large number of ChromeDriver users, and has been reported by customers in issue chromedriver:2618 , issue chromedriver:2619 , issue chromedriver:2620 , and issue chromedriver:2636 . Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
,
Nov 1
Approving merge to M71 branch 3578 based on comment #0. Pls merge ASAP. Thank you.
,
Nov 1
Pls merge your change to M71 branch 3578 ASAP so we can pick it up for next beta release. Thank you.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1f9de6f777241c055cf17611ccede599c260b89 commit a1f9de6f777241c055cf17611ccede599c260b89 Author: John Chen <johnchen@chromium.org> Date: Thu Nov 01 23:17:43 2018 [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: 901110 , 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1313336 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#466} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/a1f9de6f777241c055cf17611ccede599c260b89/chrome/test/chromedriver/chrome/chrome_impl.cc [modify] https://crrev.com/a1f9de6f777241c055cf17611ccede599c260b89/chrome/test/chromedriver/test/run_py_tests.py [modify] https://crrev.com/a1f9de6f777241c055cf17611ccede599c260b89/chrome/test/chromedriver/test/test_expectations
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1f9de6f777241c055cf17611ccede599c260b89 Commit: a1f9de6f777241c055cf17611ccede599c260b89 Author: johnchen@chromium.org Commiter: johnchen@chromium.org Date: 2018-11-01 23:17:43 +0000 UTC [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: 901110 , 868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1313336 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#466} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 5
Approved - M70.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f31af7a896ba86cd845b6c11f32e7af2499455 commit 27f31af7a896ba86cd845b6c11f32e7af2499455 Author: John Chen <johnchen@chromium.org> Date: Mon Nov 05 20:51:40 2018 [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: chromium:901110 , chromium:868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1318448 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1065} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/27f31af7a896ba86cd845b6c11f32e7af2499455/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc [modify] https://crrev.com/27f31af7a896ba86cd845b6c11f32e7af2499455/chrome/test/chromedriver/chrome/chrome_impl.h [modify] https://crrev.com/27f31af7a896ba86cd845b6c11f32e7af2499455/chrome/test/chromedriver/test/run_py_tests.py
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f31af7a896ba86cd845b6c11f32e7af2499455 Commit: 27f31af7a896ba86cd845b6c11f32e7af2499455 Author: johnchen@chromium.org Commiter: johnchen@chromium.org Date: 2018-11-05 20:51:40 +0000 UTC [ChromeDriver] Simulate maximize window when needed On environment that doesn't support maximizing window, try to simulate its effect. Bug: chromium:901110 , chromium:868599, chromedriver:2522 Change-Id: I44afe1883849a6b6396d1011fe2fe4aae38055dd Reviewed-on: https://chromium-review.googlesource.com/c/1312990 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604701}(cherry picked from commit 44f994473e625115bc9658f4d8ef49e09bcbfc5a) Reviewed-on: https://chromium-review.googlesource.com/c/1318448 Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1065} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Nov 5
All merges are complete. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by sheriffbot@chromium.org
, Nov 1