New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901107 link

Starred by 8 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

PIN enrollment menu is shown despite empty QuickUnlockModeWhitelist

Project Member Reported by vkhabarov@chromium.org, Nov 1

Issue description

ChromeOS version: 71.0.3578.27 beta
ChromeOS device model: any
Case#: 17369053

Description:
Enrolled enterprise chromebooks are showing new PIN enrollment menu for GSuite users despite PIN being disabled by policy. And it fails to setup PIN anyway.


Steps to reproduce: 
1. Make sure QuickUnlockModeWhitelist is set to [] for domain
2. Install v71 beta on Chromebook
3. Enroll Chromebook
4. Login with GSuite account

Current Behavior / Reproduction: 
Unusable PIN enrollment menu is shown (but could be skipped)

Expected Behavior: 
No PIN enrollment menu is shown

Drive link to logs: 

 
Similar issue for Public Session  crbug.com/895031 
Cc: jdufault@chromium.org zalcorn@chromium.org
Adding a couple people to CC to help find an owner as this issue is marked as RBB.
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
My guess is OOBE is not checking IsPinDisabledByPolicy, https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h?l=37&rcl=756ebd67af1e8c3f97c8d1c6f2987f4faf1dda21.
Labels: Merge-Request-71
Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e48a0bb40e77cbd22d1da2f86945c438e798b41

commit 1e48a0bb40e77cbd22d1da2f86945c438e798b41
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Nov 02 21:30:47 2018

Chrome OS: First run PIN setup should be shown only when not disabled by policy.

Bug:  901107 
Change-Id: Ieb943ad33a824318ea391b626285e6c4b8a71fc4
Reviewed-on: https://chromium-review.googlesource.com/c/1313929
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605056}
[modify] https://crrev.com/1e48a0bb40e77cbd22d1da2f86945c438e798b41/chrome/browser/chromeos/login/screens/discover_screen.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Nov 3

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Fixed)
Please keep this open until it is merged to 71. We absolutely cannot ship this bug in 71, edu and enterprise customers are already hitting it often on beta.
Cc: -zalcorn@chromium.org kbleicher@chromium.org
Status: Started (was: Assigned)
+ kbliecher m71 release manager.

- we absolutely should not ship m71 stable with this issue.
- we really need to get the fix in a m71 beta respin asap so we can confirm it solves for customers.
Cc: naveenv@chromium.org atwilson@chromium.org zalcorn@chromium.org
+ Naveen and Drew for awareness on this one. We need to make sure this is fully resolved for m71 stable or it will quickly become another fire.
Labels: -Merge-Review-71 Merge-Approved-71
Merge approved for ChromeOS M71
Merge of #5 actually depends on merge of  issue #900233 .


Cc: migue@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 7

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e57136c1f9c2098202d9c43aa527ace6d79c15

commit 19e57136c1f9c2098202d9c43aa527ace6d79c15
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Nov 07 02:50:35 2018

Chrome OS: First run PIN setup should be shown only when not disabled by policy.

TBR=alemate@chromium.org

(cherry picked from commit 1e48a0bb40e77cbd22d1da2f86945c438e798b41)

Bug:  901107 
Change-Id: Ieb943ad33a824318ea391b626285e6c4b8a71fc4
Reviewed-on: https://chromium-review.googlesource.com/c/1313929
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605056}
Reviewed-on: https://chromium-review.googlesource.com/c/1321673
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#558}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/19e57136c1f9c2098202d9c43aa527ace6d79c15/chrome/browser/chromeos/login/screens/discover_screen.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/19e57136c1f9c2098202d9c43aa527ace6d79c15

Commit: 19e57136c1f9c2098202d9c43aa527ace6d79c15
Author: alemate@chromium.org
Commiter: alemate@chromium.org
Date: 2018-11-07 02:50:35 +0000 UTC

Chrome OS: First run PIN setup should be shown only when not disabled by policy.

TBR=alemate@chromium.org

(cherry picked from commit 1e48a0bb40e77cbd22d1da2f86945c438e798b41)

Bug:  901107 
Change-Id: Ieb943ad33a824318ea391b626285e6c4b8a71fc4
Reviewed-on: https://chromium-review.googlesource.com/c/1313929
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#605056}
Reviewed-on: https://chromium-review.googlesource.com/c/1321673
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#558}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified pin unlock menu is not shown to enrolled user.  Fix was verified on veyron tiger flashed with M71 Beta 11151.24.0 71.0.3578.45
Hello team,

I was wondering if there's any update on this issue?
Issue has been fixed and merged to M-71. Are we getting any other user reports here?
I'm still getting this PIN number screen when the chromeboxes start up. I don't see any way to turn that off in our "Marmot" OU, our "OPACS" OU, or our "PUBLIC" OU. 

All of my chrome devices are public session machine. We don't have users logging into them.

On my test chromebox:

Beta Channel gets me to Google Chrome Version 71.0.3578.27 (The PIN issue remains)
Development channel gets me to Google Chrome Version 72.0.3609.3 (The PIN issue is gone, but I am not moving over 100 chrome devices to the development channel)

If you could provide me with a way to get to the Google Chrome Version 71.0.3578.45, I would appreciate it.
Beta channel should now be on 71.0.3578.71 for almost all boards - which chromeboxes do you have?
ASUS Chromebox CN60
ASUS Chromebox CN62
Maybe a few others of the same chassis type
The CN60 should have 71.0.3578.71 Beta available for update now.
Looks like the CN62 is still on 71.0.3578.27 Beta, but it should be receiving an update soon.
Those seems to be good to go now, but I do still have several Samsung Chromebook 2 13" that are still on 71.0.3578.27 (beta channel)

 

Sign in to add a comment