LibFuzzer Mac ASAN builds failing |
||||
Issue descriptionBuilds on the LibFuzzer Mac ASAN builder have been failing since 10/29 5:37 PM. https://ci.chromium.org/buildbot/chromium.fyi/Libfuzzer%20Upload%20Mac%20ASan/31288 find_sdk.py is raising an error about needing to accept the Xcode license here: https://logs.chromium.org/logs/chromium/bb/chromium.fyi/Libfuzzer_Upload_Mac_ASan/31288/+/recipes/steps/calculate_all_fuzzers/0/logs/raw_io.output_text_refs_/0 Since this file hasn't changed in a year, I wonder if something changed on the bots to break this? vhang@ or bpastene@ Do you know if something changed on the Mac bots recently that may have caused this? Or do you know who might know? Thanks!
,
Nov 1
I believe that's because the env var FORCE_MAC_TOOLCHAIN is no longer set in the builds (which changes how xcode is selected). I'll fix that.
,
Nov 1
Awesome, thanks!
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8034f41576279e1ff537d9d11437bcdf8d0fc7c1 commit 8034f41576279e1ff537d9d11437bcdf8d0fc7c1 Author: Ben Pastene <bpastene@chromium.org> Date: Thu Nov 01 22:48:26 2018 Set FORCE_MAC_TOOLCHAIN env var for mac fuzz bot. It got dropped w/ crrev.com/c/1306573. This adds it back. Bug: 901106 Change-Id: I5adc3bee0bd810b939b22dcd5501bf9da3afe117 Reviewed-on: https://chromium-review.googlesource.com/c/1313768 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/8034f41576279e1ff537d9d11437bcdf8d0fc7c1/scripts/slave/recipes/chromium_libfuzzer.expected/kitchen_paths.json [modify] https://crrev.com/8034f41576279e1ff537d9d11437bcdf8d0fc7c1/scripts/slave/recipes/chromium_libfuzzer.py [modify] https://crrev.com/8034f41576279e1ff537d9d11437bcdf8d0fc7c1/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json
,
Nov 2
And it's green: https://ci.chromium.org/buildbot/chromium.fyi/Libfuzzer%20Upload%20Mac%20ASan/ Turns out an earlier change of mine was responsible for breaking it in the first place. Sry about that.
,
Nov 2
Great, thanks for fixing. |
||||
►
Sign in to add a comment |
||||
Comment 1 by no...@chromium.org
, Nov 1