New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901091 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Layout tests are failing on the code coverage bots

Project Member Reported by mmoroz@chromium.org, Nov 1

Issue description

Looks like the launcher has changed a couple days ago and now it does not recognize some of the parameters it used to have: https://chromium-coverage.appspot.com/reports/603897/linux/metadata/layout_tests.log


 
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
Erik, looks like your CL broke the workflow of code coverage bots: https://chromium-review.googlesource.com/c/chromium/src/+/1300236

Would it be possible to bring --batch-size option back? Or is there any alternative flag we should use?

Cc: erikc...@chromium.org
Owner: mmoroz@chromium.org
Status: Started (was: Assigned)
Actually, hold on, we might be able to get coverage data now even from crashing processes. Let me just try to run that without --batch-size=1 and check the results.
Cc: dpranke@chromium.org
"--batch-size=1" is now equivalent to "--restart-shell-between-tests". Could you try passing that parameter and see if that fixes the problem?
Cc: nednguyen@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/f8fbc92e3be5575557e097aa178f20a1588a7537

commit f8fbc92e3be5575557e097aa178f20a1588a7537
Author: Max Moroz <mmoroz@google.com>
Date: Thu Nov 01 20:44:50 2018

Erik, thanks for the hint! I'll see if we get proper data without that option (I still believe that it should be possible now, since we've figured out how to dump profiles from crashing processes). If there is any problem, we'll proceed with "--restart-shell-between-tests" then.
Status: Fixed (was: Started)
Everything looks great! Erik, thanks for deleting that argument and breaking the script for us. Otherwise, I would not remember that we do not need --batch-size=1 anymore. Now, code coverage bot runs layout tests in 45 minutes instead of 2 hours. Awesome!

Sign in to add a comment