Problems reported by 0day in chromeos-4.19 |
|||
Issue descriptionmm/low-mem-notify.c:35:10: warning: symbol 'low_mem_margin_mb' was not declared. Should it be static? >> mm/low-mem-notify.c:93:17: warning: incorrect type in initializer (different base types) mm/low-mem-notify.c:93:17: expected restricted __poll_t ( *poll )( ... ) mm/low-mem-notify.c:93:17: got unsigned int ( *<noident> )( ... ) --
,
Nov 1
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b7ec7fb624dfc8d07e722cf2e0e72ff82ebaec7b commit b7ec7fb624dfc8d07e722cf2e0e72ff82ebaec7b Author: Guenter Roeck <groeck@chromium.org> Date: Fri Nov 02 03:35:19 2018 CHROMIUM: low-mem: Fix return type of low_mem_notify_poll 0day complains: mm/low-mem-notify.c:35:10: warning: symbol 'low_mem_margin_mb' was not declared. Should it be static? >> mm/low-mem-notify.c:93:17: warning: incorrect type in initializer (different base types) mm/low-mem-notify.c:93:17: expected restricted __poll_t ( *poll )( ... ) mm/low-mem-notify.c:93:17: got unsigned int ( *<noident> )( ... ) Make it happy by using the correct return type. Also, while at it, declare low_mem_margin_mb as static variable BUG=chromium:901090 TEST=Check build with static checkers Change-Id: Ib5fe5d06fdc8ff8a36f5db4c57a69cd40ace567a Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1313588 Reviewed-by: Luigi Semenzato <semenzato@chromium.org> [modify] https://crrev.com/b7ec7fb624dfc8d07e722cf2e0e72ff82ebaec7b/mm/low-mem-notify.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/97eadfb42cdb436943e6534d8fe1730850db14d7 commit 97eadfb42cdb436943e6534d8fe1730850db14d7 Author: Guenter Roeck <groeck@chromium.org> Date: Tue Nov 27 04:31:16 2018 CHROMIUM: cros_ec: Fix return value from of ec_device_poll 0day complains: drivers/mfd/cros_ec_dev.c:222:23: warning: incorrect type in return expression (different base types) __poll_t expects EPOLLIN / EPOLLRDNORM instead of POLLIN / POLLRDNORM as return values. The actual defines are the same, so there is no practical impact from using the wrong defines, but we should still return values from the same base types. BUG=chromium:901090 TEST=Test file with static analyzers Change-Id: Id128dae3344eb29d1692410c609a3efccaf3633e Signed-off-by: Guenter Roeck <groeck@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1342685 Reviewed-by: Benson Leung <bleung@chromium.org> [modify] https://crrev.com/97eadfb42cdb436943e6534d8fe1730850db14d7/drivers/mfd/cros_ec_dev.c |
|||
►
Sign in to add a comment |
|||
Comment 1 by groeck@chromium.org
, Nov 1