New issue
Advanced search Search tips

Issue 901083 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Outer viewport clip node has incorrect bounds

Project Member Reported by bokan@chromium.org, Nov 1

Issue description

Chrome Version: 72.0.3590.0
OS: Android

On Android, the outer (layout) viewport is sized using the minimum-page-scale which depends on the content-size. This originates in WebViewImpl::ResizeAfterLayout.

On a page like https://ritzy-green.glitch.me/ (attached for reference), the content is 320 pixels, so on a device with a larger screen, the content is laid out into 320 pixels of width. This means the minimum-scale is > 1 so the page loads zoomed in and the layout viewport is less wide than the device screen.

The resize-after-layout affects both the FrameView and the LayoutView size so I would expect the ClipNode belonging to the outer viewport to also have the resize applied but it doesn't - it's the same size as the visual viewport's clip. This is the root cause of  bug 898757 . That bug needs a mergeable fix so this bug tracks fixing the root cause.

The clip is correctly calculated with --enable-blink-gen-property-trees so perhaps just letting that ship is enough.
 
index (1).html
4.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6426e398c74b4f61ff9a62bdc22d2b66b9fff0f

commit a6426e398c74b4f61ff9a62bdc22d2b66b9fff0f
Author: David Bokan <bokan@chromium.org>
Date: Fri Nov 16 19:04:33 2018

Add test for viewport clipping issue

In https://crrev.com/f9cbcfa426bdf0cb830cd7d1ce7cc80845184d3e I landed
a fix to  https://crbug.com/898757 . This fix was needed ASAP since it
needed to be merged. I landed a fix without a test at the time. This CL
adds a test.

Bug: 901083, 898757 
Change-Id: I0b3dc44a7e94e33f5897f7d9f19159523807dc56
Reviewed-on: https://chromium-review.googlesource.com/c/1336786
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608880}
[modify] https://crrev.com/a6426e398c74b4f61ff9a62bdc22d2b66b9fff0f/cc/trees/layer_tree_host_impl_unittest.cc

Sign in to add a comment