New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901037 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Refactor the usb peripherals tests in usb_detect suite

Project Member Reported by ka...@chromium.org, Nov 1

Issue description

There are 14 tests part of the platform_ExternalUsbPeripherals versions. 
We are running 8 out of these 14 - https://screenshot.googleplex.com/210px1as9tn
Having other suite(s) are running on the same pool, there is quite a bit autotest overhead, that can limit the bandwidth. 
Also from efficiency stand point we should probably not run some tests that are part of others. 
Some should be removed as they are outdated.


1) Remove control files that we have no intent to use (anymore), like:
- control.printer
- control.stress2
- control.stress3
- control.usb_detect.crashes

2) Remove control files that are redundant, like:
- control.detect.login_unplug_plug
- control.detect.reboot_login
- control.detect.unplug_plug


3) Further having we are to consolidate some series of tests we can remove the following

- CLOSE_LID based
control.detect.login_closelid_openlid
control.detect.login_closelid_unplug_openlid_plug
control.detect.login_unplug_closelid_plug_openlid

- SUSPEND_RESUME based
control.detect.login_suspend_resume
control.detect.login_suspend_unplug_resume_plug
control.detect.login_unplug_suspend_plug_resume
control.detect.login_unplug_suspend_resume_plug


4) Other suggestions

- We can try adding LOGOUT step
- We can combine suspend-resume and close_lid-open_lid (like the real scenario - left the laptop to suspend and then close the lid to commute to work)

As a result we can form no more than 4 scenarios we can use for perbuild suite runs.

If we need some other, like tracking crashes, or repetitive/stress types of tests, we can put add to nightly or weekly schedule.



 
 
Prasanthi, please proceed with 1) and 2)

Matt, proceed with 3) and remove these files, but add scenarios like

- consolidated long cycle of combined steps like:
    default_actions = str("reboot,plug,unplug,"
                          "login,plug,unplug,"
                          "reboot,plug,login,unplug,plug,"
                          "reboot, unplug,login,plug"
                          "suspend,resume,"
                          "unplug,suspend,plug,resume,"
                          "suspend,unplug,resume,plug")
    I tested this one. It has 25 steps and PASSed in ~15 min.

- one crash checking shorter cycle like
    default_actions = str("plug,unplug,login,plug,unplug,
                          "suspend,plug,resume,suspend,unplug,resume")

- one lid close open shorter cycle like
    default_actions = str("plug,unplug,login,plug,"
                          "closelid,unplug,openlid,"
                          "closelid,plug,openlid,unplug")

Sridhar, lets implements the LOGOUT step.

This was done before by posting(touch) the temp file  /tmp/simple_login_exit when the Login client test is called without 
'exit_without_logout=True'.

LMK what you think
Labels: -Type-Bug Type-Task
Submitted CL +/1318449 for 1) & 2) 
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f3ad8e52a05dc36be6982469e0fe72a167958f34

commit f3ad8e52a05dc36be6982469e0fe72a167958f34
Author: Prasanthi Gangishetty <pgangishetty@chromium.org>
Date: Wed Nov 07 14:34:22 2018

Remove control files

Remove control files that are redundant and have no intent to use

BUG:chromium:901037
TEST=None

Change-Id: I94c9b281841040eedfee025d943e9bd123811135
Reviewed-on: https://chromium-review.googlesource.com/1318449
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Prasanthi Gangishetty <pgangishetty@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_plug
[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.printer
[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.usb_detect.crashes
[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.stress3
[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.stress2
[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.detect.reboot_login
[delete] https://crrev.com/b734bacef0d586c927cbf7f9d6ad1120728c3939/server/site_tests/platform_ExternalUsbPeripherals/control.detect.unplug_plug

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/56836d47e70fc7d2c5bfbfc9a11578960e1112e0

commit 56836d47e70fc7d2c5bfbfc9a11578960e1112e0
Author: Matt Nelson <matthewjoseph@chromium.org>
Date: Thu Nov 29 20:11:13 2018

Adding refactored control files for platform_ExternalUsbPeriphals
autotests
- Removed 5 redundant files
- Leaving 3 files for long, short, and short with crash tracking sequence.

BUG:chromium:901037
TEST=None

Change-Id: I7cb1f2e0100e4f8d0dbf86875197d9fb8365f2d9
Reviewed-on: https://chromium-review.googlesource.com/1351355
Commit-Ready: Matt Nelson <matthewjoseph@chromium.org>
Tested-by: Matt Nelson <matthewjoseph@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[delete] https://crrev.com/37f88ed36d1c4e8654f970cd0feea272de31b4a3/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_suspend_unplug_resume_plug
[delete] https://crrev.com/37f88ed36d1c4e8654f970cd0feea272de31b4a3/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_resume_plug
[delete] https://crrev.com/37f88ed36d1c4e8654f970cd0feea272de31b4a3/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_suspend_plug_resume
[delete] https://crrev.com/37f88ed36d1c4e8654f970cd0feea272de31b4a3/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_unplug_closelid_plug_openlid
[copy] https://crrev.com/56836d47e70fc7d2c5bfbfc9a11578960e1112e0/server/site_tests/platform_ExternalUsbPeripherals/control.detect.crash_check_short
[rename] https://crrev.com/56836d47e70fc7d2c5bfbfc9a11578960e1112e0/server/site_tests/platform_ExternalUsbPeripherals/control.detect.long_cycle
[delete] https://crrev.com/37f88ed36d1c4e8654f970cd0feea272de31b4a3/server/site_tests/platform_ExternalUsbPeripherals/control.detect.login_closelid_unplug_openlid_plug
[rename] https://crrev.com/56836d47e70fc7d2c5bfbfc9a11578960e1112e0/server/site_tests/platform_ExternalUsbPeripherals/control.detect.lid_close_open_short

Sign in to add a comment