New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 901025 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

UMA for failed loading of MHTML files

Project Member Reported by iwells@chromium.org, Nov 1

Issue description

Chrome Version: any
OS: all

The result of attempting to load an MHTML archive isn't reported. Metrics to do with how often loading fails due to the archive being invalid should be collected.




 
Cc: carlosk@chromium.org
Components: UI>Browser>Offline
Status: Assigned (was: Fixed)
Thanks for creating this issue!
I'm reopening as this work is still ongoing and also updating a few tags.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4add91cbce4d83efe3f03544f706c1576388017

commit f4add91cbce4d83efe3f03544f706c1576388017
Author: Ian Wells <iwells@chromium.org>
Date: Sat Nov 17 01:23:05 2018

Added MHTML loading status metric

This change causes results of attempts to load MHTML archives to be
logged with a UMA histogram, providing some previously missing insight into the
performance of MHTML loading.

Bug: 901025
Change-Id: If82fda621fcf8d4256edc20a0da9172d0cde2455
Reviewed-on: https://chromium-review.googlesource.com/c/1313669
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609062}
[modify] https://crrev.com/f4add91cbce4d83efe3f03544f706c1576388017/third_party/blink/renderer/core/frame/mhtml_archive_test.cc
[modify] https://crrev.com/f4add91cbce4d83efe3f03544f706c1576388017/third_party/blink/renderer/platform/mhtml/mhtml_archive.cc
[modify] https://crrev.com/f4add91cbce4d83efe3f03544f706c1576388017/third_party/blink/renderer/platform/mhtml/mhtml_archive.h
[modify] https://crrev.com/f4add91cbce4d83efe3f03544f706c1576388017/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f4add91cbce4d83efe3f03544f706c1576388017/tools/metrics/histograms/histograms.xml

Sign in to add a comment