Lower minidump reporting fraction for 70 stable |
|||||||||
Issue descriptionWe forgot to lower the minidump reporting fraction for 70 stable (see issue 865357 for the previous version of this). We're going to do this on a minibranch.
,
Nov 1
Approved. Please merge to 3538_80.
,
Nov 1
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a6b3548743fa4e1a2dc7f12b4ca9f6a2762f6a8 commit 1a6b3548743fa4e1a2dc7f12b4ca9f6a2762f6a8 Author: Torne (Richard Coles) <torne@google.com> Date: Thu Nov 01 17:50:52 2018 Lower minidump generation fraction to 1% for stable. To avoid hitting the cap on the number of uploaded crash reports per day we lower the fraction of uploaded reports from 100% for Beta to 1% for Stable. TBR=tobiasjs@chromium.org Bug: 901003 Change-Id: I4d356ef5148e24fffec9f6de6c0044fa2cb6735f Reviewed-on: https://chromium-review.googlesource.com/c/1312164 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/branch-heads/3538_80@{#3} Cr-Branched-From: 71ebef4364b3f23d449014dc9701618190985319-refs/branch-heads/3538@{#1046} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/1a6b3548743fa4e1a2dc7f12b4ca9f6a2762f6a8/android_webview/common/crash_reporter/aw_crash_reporter_client.cc
,
Nov 1
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4976956a14ebaca0f381e8d7f6b4241290aaf19d commit 4976956a14ebaca0f381e8d7f6b4241290aaf19d Author: Torne (Richard Coles) <torne@google.com> Date: Thu Nov 01 18:50:14 2018 Lower minidump generation fraction to 1% for stable. To avoid hitting the cap on the number of uploaded crash reports per day we lower the fraction of uploaded reports from 100% for Beta to 1% for Stable. TBR=tobiasjs@chromium.org Bug: 901003 (cherry picked from commit 1a6b3548743fa4e1a2dc7f12b4ca9f6a2762f6a8) Change-Id: I4d356ef5148e24fffec9f6de6c0044fa2cb6735f Reviewed-on: https://chromium-review.googlesource.com/c/1312164 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3538_80@{#3} Cr-Original-Branched-From: 71ebef4364b3f23d449014dc9701618190985319-refs/branch-heads/3538@{#1046} Cr-Original-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} Reviewed-on: https://chromium-review.googlesource.com/c/1312167 Cr-Commit-Position: refs/branch-heads/3538@{#1059} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/4976956a14ebaca0f381e8d7f6b4241290aaf19d/android_webview/common/crash_reporter/aw_crash_reporter_client.cc
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4976956a14ebaca0f381e8d7f6b4241290aaf19d Commit: 4976956a14ebaca0f381e8d7f6b4241290aaf19d Author: torne@google.com Commiter: torne@chromium.org Date: 2018-11-01 18:50:14 +0000 UTC Lower minidump generation fraction to 1% for stable. To avoid hitting the cap on the number of uploaded crash reports per day we lower the fraction of uploaded reports from 100% for Beta to 1% for Stable. TBR=tobiasjs@chromium.org Bug: 901003 (cherry picked from commit 1a6b3548743fa4e1a2dc7f12b4ca9f6a2762f6a8) Change-Id: I4d356ef5148e24fffec9f6de6c0044fa2cb6735f Reviewed-on: https://chromium-review.googlesource.com/c/1312164 Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3538_80@{#3} Cr-Original-Branched-From: 71ebef4364b3f23d449014dc9701618190985319-refs/branch-heads/3538@{#1046} Cr-Original-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} Reviewed-on: https://chromium-review.googlesource.com/c/1312167 Cr-Commit-Position: refs/branch-heads/3538@{#1059} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Nov 16
Minidump not uploading, verified on Pixel XL / OPM1.180608.001,Nexus 5X / N2G48L on latest M70 build.
,
Nov 16
@torne minidump not uploading on Nexus 6P/OPM1.180608.001 however when we enable the flag using adb, Are we expected to see the mini dump reporting when flags enabled ? .Is it still hold good ?. Sorry for asking this question again & again.
,
Nov 16
Because we missed doing this for the initial M70 releases, the server has been configured to sample the M70 crashes, and is throwing 99% of crash reports away if they come from 70.* This means that you are unlikely to see any particular crash appear on the server, no matter what flags you enable, so it's not feasible to test this by looking on the server; the only thing you can verify right now is the behaviour you see in logcat on the device. We need to have the serverside configuration changed before we release the new M70 build to only apply to the older M70 versions, because otherwise we'll only be getting 1% of 1% of the crashes which is too few - once that's been done you should be able to test it as normal with the new build.
,
Nov 16
torne@, thank you for the detailed explanation. It explains #9 observation.
,
Nov 16
Verified in the logcat , we see a shell browser crash on Nexus 6P/OPM1.180608.001 having 70.0.3578.110 .
,
Nov 16
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by torne@google.com
, Nov 1