Issue metadata
Sign in to add a comment
|
Crosperf cannot collect profile correctly using autotest profiler |
||||||||||||||||||||||||
Issue descriptionWhen collecting perf data for telemetry_crosperf, autotest's profiling framework has several issues make this progress not reliable: 1. There is issue for autotest to access the port on lab machine for profiling. 2. The benchmark started with some login operations, and we don't want perf to collect them. 3. Autotest is getting deprecated and the new framework does not support profiler. Thus, we want to replace the profiler control process we use now.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b5f80d25ab6190c12dd15948420827f4a4c1149b commit b5f80d25ab6190c12dd15948420827f4a4c1149b Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Nov 07 14:34:26 2018 telemetry_crosperf: do not use profiler in autotest for profiling This patch rewrites the profiling mechanism in telemetry_crosperf. It was using autotest profiler before and causing several issues: https://crbug.com/900992 . We want to do profiling manually, where we run benchmark at DUT background and then run perf on DUT to collect profiles. BUG= chromium:900992 TEST=Tested with telemetry_crosperf_profiler with octane benchmark on two peach_pit devices in parallel. Change-Id: I7d8f3952c6324a11fa117f2759ff65a92a5d11ef Reviewed-on: https://chromium-review.googlesource.com/1313539 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> [modify] https://crrev.com/b5f80d25ab6190c12dd15948420827f4a4c1149b/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py [modify] https://crrev.com/b5f80d25ab6190c12dd15948420827f4a4c1149b/server/site_tests/telemetry_Crosperf/control
,
Nov 7
Marking this as fixed. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by zhizhouy@chromium.org
, Nov 3