New issue
Advanced search Search tips

Issue 900982 link

Starred by 1 user
Status: Fixed
Owner:
aleventhal@chromium.org
Closed: Nov 5
Cc:
aboxhall@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Keep hidden objects in tree so that events can be fired on them

Project Member Reported by aleventhal@chromium.org, Nov 1 
When an object is hidden with aria-hidden="true" it should still be exposed to in accessible object hierarchies, but just marked as invisible. This allows events to be fired on them in the odd case they occur (the elements are technically still focusable). It is also more similar to how Firefox and Safari exposes content.

Comment 1 by aleventhal@chromium.org, Nov 1

Components: Blink>Accessibility

Comment 2 by aleventhal@chromium.org, Nov 1

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d665849b15151f7a582b29765333757776dda8

commit 58d665849b15151f7a582b29765333757776dda8
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Nov 05 23:04:10 2018

Keep focusable aria-hidden objects in AX tree marked as invisible

Also:
- Fixes a bug where updating tabindex on a node did not update its
focusable state.
- Removes hack for hiding objects from NVDA virtual buffer by providing a null accName.
It turns out that using a hidden:true object attribute works and is preferred by NVDA,
which for historical reasons ignores the INVISIBLE state.

Bug:  900982 
Change-Id: I7611d3c3e2da3d6b3f22e40e69189579d15b580e
Reviewed-on: https://chromium-review.googlesource.com/c/1312675
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605506}
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/browser/accessibility/dump_accessibility_events_browsertest.cc
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-descendant-tabindex-change-expected-blink.txt
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-descendant-tabindex-change.html
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-descendants-expected-blink.txt
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-descendants.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-expected-android.txt
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-expected-blink.txt
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-expected-mac.txt
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-expected-win.txt
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-iframe-body-expected-blink.txt
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden-iframe-body.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/aria/aria-hidden.html
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-added-on-aria-hidden-expected-win.txt
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-added-on-aria-hidden.html
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-added-on-plain-div-expected-win.txt
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-added-on-plain-div.html
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-removed-on-aria-hidden-expected-win.txt
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-removed-on-aria-hidden.html
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-removed-on-plain-div-expected-win.txt
[add] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/content/test/data/accessibility/event/tabindex-removed-on-plain-div.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/WebKit/LayoutTests/accessibility/aria-hidden-hides-all-elements-expected.txt
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/WebKit/LayoutTests/accessibility/aria-hidden-hides-all-elements.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/WebKit/LayoutTests/accessibility/aria-hidden-update.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/WebKit/LayoutTests/accessibility/aria-hidden-updates-alldescendants.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/WebKit/LayoutTests/accessibility/aria-hidden-with-elements.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/WebKit/LayoutTests/accessibility/contenteditable-on-aria-hidden-body.html
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/blink/renderer/modules/accessibility/ax_object.h
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/58d665849b15151f7a582b29765333757776dda8/ui/accessibility/platform/ax_platform_node_win.cc

Comment 4 by aleventhal@chromium.org, Nov 5

Status: Fixed (was: Started)
►

Sign in to add a comment