New issue
Advanced search Search tips

Issue 900972 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Nov 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Properly run VR tests on Android CFI

Project Member Reported by bsheedy@chromium.org, Nov 1 
The Android CFI bot currently runs the VR instrumentation tests, but does not do the proper setup for them. They *usually* work because at this point, most Nexus 5Xs have VrCore installed from 2 years of VR testing, but in cases where it isn't installed (like a freshly reflashed device), the tests end up failing.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9eb60b5db786434c7164a01a6bb961ec9216f612

commit 9eb60b5db786434c7164a01a6bb961ec9216f612
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Nov 01 18:31:32 2018

Make Android CFI download VR APKs

Adds the download_vr_test_apks chromium config to Android CFI. This is
the first step to getting Android CFI to properly run the VR tests
instead of relying on VrCore being pre-installed on the test device
by luck.

Bug:  900972 
Change-Id: Ifa7e7b7e3014f9189fa4bac7f3116cfc630910b3
Reviewed-on: https://chromium-review.googlesource.com/c/1312203
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>

[modify] https://crrev.com/9eb60b5db786434c7164a01a6bb961ec9216f612/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c

commit df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Nov 01 19:42:16 2018

Fix non-Daydream VR instrumentation test suites

Fixes the way the VR instrumentation tests are configured on
non-Daydream-ready devices (the chrome_public_test_vr_apk test suite)
so that all users have the necessary args instead of adding the args
in test_suite_exceptions.

This should be both cleaner and help catch future cases of the tests
being enabled on bots they shouldn't be, as the tests should immediately
fail due to trying to install VrCore without the APK being downloaded
instead of having a chance of passing due to VrCore happening to be
installed on the test device already.

Bug:  900972 
Change-Id: I742621ab3696803b5f434a9b841f56cccda28879
Reviewed-on: https://chromium-review.googlesource.com/c/1313072
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604671}
[modify] https://crrev.com/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c/testing/buildbot/chromium.android.json
[modify] https://crrev.com/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/df58b4ec9b76bfb8b700da1284e7d6bb63dd7c7c/testing/buildbot/test_suites.pyl

Comment 3 by bsheedy@chromium.org, Nov 2

Status: Fixed (was: Assigned)
As of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3495, Android CFI properly downloads and installs VrCore.
►

Sign in to add a comment