Entering overview should cancel window drag if there is any |
|||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome What steps will reproduce the problem? (1) In laptop mode, open a few browser or app windows (2) Use the mouse to click on the title area of one of the windows and don't release the mouse (3) At the same time press on the overview key on the keyboard What is the expected result? The drag is cancelled and we enter overview What happens instead? All other windows enters overview except the dragged window Min, can you take a look? Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 2
Talked with Daisy offline and found more corner cases of this. In tablet mode, if plug in an external keyboard the device will keep in tablet mode. 1. Drag an app window from top will toggle overview mode behind. Press the overview key in keyboard in this case will see home launcher behind. Press again will see crash happened. 2. Drag a tab from multi-tabs, which will not toggle overview mode behind. Press the overview key in keyboard in this case will see crash happened. In clamshell mode, we can see the scenario in the description above. Ben, not sure what's the expect behavior in these cases. Should we 1. Put the dragged window into overview if press the overview key in the keyboard in all of the cases and revert the window drag? Or 2. Just disable the shortcut of pressing overview button in the keyboard when a window is being draggeg?
,
Nov 2
Hey Min, Active drags should disable keyboard shortcuts or button presses that trigger conflicting actions. Tapping the home launcher or overview buttons on screen with one hand while dragging a tab/app in the other is another way you can currently trigger these kinds of conflicts without the keyboard. They should be disabled too while dragging - tap targets in general, actually. Shelf, quick settings, other Chrome controls, none of these should be actionable while dragging.
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee1999fc53e953e313f5bea42e805f9bff5968fb commit ee1999fc53e953e313f5bea42e805f9bff5968fb Author: Min Chen <minch@google.com> Date: Tue Nov 06 22:08:12 2018 Disable the toggle overview shortcut if a window is being dragged. Bug: 900959 Change-Id: Iae62ce77d2fd38105120d86799e52157d6313f3c Reviewed-on: https://chromium-review.googlesource.com/c/1313738 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605840} [modify] https://crrev.com/ee1999fc53e953e313f5bea42e805f9bff5968fb/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/ee1999fc53e953e313f5bea42e805f9bff5968fb/ash/wm/overview/window_selector_controller_unittest.cc [modify] https://crrev.com/ee1999fc53e953e313f5bea42e805f9bff5968fb/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/ee1999fc53e953e313f5bea42e805f9bff5968fb/testing/buildbot/filters/chromeos.single_process_mash.ash_unittests.filter
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48f5e54a0913e3ede2b9c53b158233618d4a1ebd commit 48f5e54a0913e3ede2b9c53b158233618d4a1ebd Author: Min Chen <minch@google.com> Date: Thu Nov 15 18:22:05 2018 Handle the none-drag gesture events during window drag. Set the gesture event as handled if it can not be used to drag the window during window drag. Browser window is special since it has its own logic to handle the drag. Bug: 900959 , 877976 Change-Id: I6a9416505da7fc92306ad5c364f4be04213dd992 Reviewed-on: https://chromium-review.googlesource.com/c/1332289 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608442} [modify] https://crrev.com/48f5e54a0913e3ede2b9c53b158233618d4a1ebd/ash/BUILD.gn [modify] https://crrev.com/48f5e54a0913e3ede2b9c53b158233618d4a1ebd/ash/wm/immersive_gesture_drag_handler.cc [add] https://crrev.com/48f5e54a0913e3ede2b9c53b158233618d4a1ebd/ash/wm/immersive_gesture_drag_handler_unittest.cc [modify] https://crrev.com/48f5e54a0913e3ede2b9c53b158233618d4a1ebd/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/48f5e54a0913e3ede2b9c53b158233618d4a1ebd/ash/wm/tablet_mode/tablet_mode_app_window_drag_controller.h
,
Nov 15
|
|||
►
Sign in to add a comment |
|||
Comment 1 by minch@chromium.org
, Nov 1