New issue
Advanced search Search tips

Issue 900954 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Make crash keys whitelist to accept keys with suffix counter

Project Member Reported by hazems@chromium.org, Nov 1

Issue description

Crash keys values are fixed length so whenever the value field is too long it's split to many fields with suffix counter (key__1, key__2, ...). In webview, we have to explicitly hardcode the keys and the counters in the whitelist:

https://cs.chromium.org/chromium/src/android_webview/common/crash_reporter/crash_keys.cc

It'd be better to fix the whitelist to accept keys without/with any numeric suffix instead of hardcoding the numbers.
 
Description: Show this description
Cc: rsesek@chromium.org jperaza@chromium.org
Description: Show this description
Android is going to be switching from Breakpad to Crashpad Real Soon Now™. In Crashpad, keys are not chunked into counter-suffixed keys, so I think this will become moot.

Sign in to add a comment