New issue
Advanced search Search tips

Issue 900950 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

TypeError on chrome-signin page

Project Member Reported by mcnee@chromium.org, Nov 1

Issue description

Chrome Version: 72.0.3597.0

On chrome://chrome-signin/ I see the following Error:

Error in event handler: TypeError: Error in invocation of webRequestInternal.eventHandled(string eventName, string subEventName, string requestId, optional webRequest.BlockingResponse response): Error at parameter 'response': Unexpected property: 'frameId'.
    at subEventCallback (extensions::webRequestEvent:106:28)
 
Owner: hendrich@chromium.org
Status: Assigned (was: Untriaged)
This started happening in
https://chromium.googlesource.com/chromium/src/+/d76e906c94a8436ac136fd0652bc97961fb7d477

Assigning to the author.
Status: Started (was: Assigned)
I'll take a look. Thanks for filing the bug.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b752742ac2e7d85d2a568a4c512f6603ebf4f13

commit 3b752742ac2e7d85d2a568a4c512f6603ebf4f13
Author: Alexander Hendrich <hendrich@chromium.org>
Date: Wed Nov 07 10:46:02 2018

Fix TypeError in webRequestInternal.eventHandled

This CL is a followup to 1296539 and fixes a TypeError in
webRequestInternal.eventHandled() caused by this CL.
onHeadersReceived_ previously only returned headers when they contained
a SAML_HEADER, but the fix CL always returned all headers.

Bug:  900950 , 887061
Change-Id: Ic39e2bd6a98c6e2e3411812f7cd90310c32e1d3b
Reviewed-on: https://chromium-review.googlesource.com/c/1314471
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606011}
[modify] https://crrev.com/3b752742ac2e7d85d2a568a4c512f6603ebf4f13/chrome/browser/resources/gaia_auth_host/saml_handler.js

Status: Fixed (was: Started)
Labels: TE-Verified-M72 TE-Verified-72.0.3605.0
Able to reproduce this issue on Ubuntu 17.10 on the reported version 72.0.3597.0 and the issue is fixed on the latest M-72 build 72.0.3605.0.

1. Launched Chrome and navigated to chrome://chrome-signin.
2. on navigating to devtools -> Console, cannot observe the error 'TypeError: Error in invocation of webRequestInternal.eventHandled(string eventName, string subEventName, string requestId, optional webRequest.BlockingResponse response): Error at parameter 'response': Unexpected property: 'frameId'.at subEventCallback (extensions::webRequestEvent:106:28)'

Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
900950-M72.png
234 KB View Download

Sign in to add a comment