BackgroundSync can think it's online when it's offline |
||||||||||
Issue descriptionThe BackgroundSyncNetworkObserver's call to GetConnectionType() on startup won't update the connection type if the call returns synchronously. By default the manager thinks the network type is unknown (therefore online). So if it's actually offline then the background sync manager won't know this and will fire its events anyway.
,
Nov 2
Requesting merge into M71 as this is a pretty bad bug and a small fix. So far Chrome Canary seems okay.
,
Nov 2
Pls apply appropriate OSs label.
,
Nov 2
,
Nov 2
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
Updated priority and rerequesting merge.
,
Nov 2
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
Approving merge to M71 branch 3578 based on comment #2. Please merge ASAP. Thank you.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/562022db7ba4767c4764574b2c01c714560f1305 commit 562022db7ba4767c4764574b2c01c714560f1305 Author: Josh Karlin <jkarlin@chromium.org> Date: Mon Nov 05 13:15:12 2018 [BackgroundSync] BGSync missing its initial connection type request After the switch to NetworkConnectionTracker, the GetConnectionType call wasn't checking for a synchronous return. In the case of a synchronous return OnConnectionChanged needs to be called. This led to BackgroundSyncManager not getting the correct connection type on startup. Bug: 900943 Change-Id: I21ffcacdea9cca4c0780f40561e55b10fb9866b1 Reviewed-on: https://chromium-review.googlesource.com/c/1312676 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604689}(cherry picked from commit bf943695d0c24fed3f7a1b90566e66b5a8482c36) Reviewed-on: https://chromium-review.googlesource.com/c/1317829 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#495} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/562022db7ba4767c4764574b2c01c714560f1305/content/browser/background_sync/background_sync_network_observer.cc [modify] https://crrev.com/562022db7ba4767c4764574b2c01c714560f1305/content/browser/background_sync/background_sync_network_observer.h [modify] https://crrev.com/562022db7ba4767c4764574b2c01c714560f1305/content/browser/background_sync/background_sync_network_observer_unittest.cc
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/562022db7ba4767c4764574b2c01c714560f1305 Commit: 562022db7ba4767c4764574b2c01c714560f1305 Author: jkarlin@chromium.org Commiter: jkarlin@chromium.org Date: 2018-11-05 13:15:12 +0000 UTC [BackgroundSync] BGSync missing its initial connection type request After the switch to NetworkConnectionTracker, the GetConnectionType call wasn't checking for a synchronous return. In the case of a synchronous return OnConnectionChanged needs to be called. This led to BackgroundSyncManager not getting the correct connection type on startup. Bug: 900943 Change-Id: I21ffcacdea9cca4c0780f40561e55b10fb9866b1 Reviewed-on: https://chromium-review.googlesource.com/c/1312676 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604689}(cherry picked from commit bf943695d0c24fed3f7a1b90566e66b5a8482c36) Reviewed-on: https://chromium-review.googlesource.com/c/1317829 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#495} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 5
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 1