Issue metadata
Sign in to add a comment
|
A keyboard shortcut defined in an extension manifest is no longer acted upon
Reported by
jasonjgw...@gmail.com,
Nov 1
|
||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
Steps to reproduce the problem:
1. In the manifest.json file of an extension, a keyboard shortcut to open the popup is defined as follows:
"commands": {
"_execute_browser_action": {
"suggested_key": {
"default": "Alt+Shift+O",
"mac": "Alt+Shift+O"
},
"description": "Open popup window"
}
},
2. Enable the extension in chrome://extensions
3. Type the defined keyboard shortcut (in our example, Alt+Shift+O).
What is the expected behavior?
The popup is presented and focus moves there.
What went wrong?
The popup is not presented and focus is not moved (i.e., the keyboard binding is not acted on).
Did this work before? Yes 69
Does this work in other browsers? N/A
Chrome version: 70.0.3538.77 Channel: stable
OS Version: 10.0
Flash Version:
As I recall, this was working in Chrome 69. A colleague and I tested it under Chrome 70 (Windows 10 and Mac OS respectively) and reproduced this issue in both environments.
,
Nov 2
,
Nov 2
I'm seeing erratic behavior, with MacOSX 10.13.4 and Chrome 70.0.3538.77. I tested variations on key combos with the sample extension (mentioned by woxxom): - `Ctrl-Shift-F` does work (opens and focuses the popup) - `Alt-Shift` doesn't seem to work at all, with any other character key I tested - `Ctrl-Shift-O` does work - some other combinations of keys don't work for me, with no obvious pattern. I also tested with another extension (with more extensive features), duplicating (copy-paste) the relevant key-value objects in the manifest as a control. (I disabled the sample extension while testing so there wouldn't be conflicts.) - `Ctrl-Shift-F` does work (opens and focuses the popup) - `Alt-Shift` still doesn't work at all - `Ctrl-Shift-O` does NOT work, even though it worked with the simpler sample extension - As with the sample extension, some other combinations of keys don't work for me, with no obvious pattern. Definitely something funky going on. Please note that this is an accessibility issue. One of my extensions is geared specifically for people with disabilities. They have difficulty navigating to and activating the popup through serial (tab) control, and rely heavily on keyboard shortcuts. The proper behavior works wonderfully, not only activating the popup (which provides additional accessibility information about the page), but also automatically shifting focus to the popup when it opens, then back to the previous point of focus on the main page when the popup is closed again with the same keyboard shortcut; just perfect. This breaking regression error severely decreases the UX and utility of my extension. I really appreciate your looking into it.
,
Nov 2
Unable to reproduce the issue on Win-10 and mac 10.13.6 using chrome reported version #70.0.3538.77 and latest canary #72.0.3598.0. Attached a screen cast for reference. Following are the steps followed to reproduce the issue. ------------ 1. Opened the extension from comment #1. 2. Pressed Ctrl+shift+F. 3. Observed that pressing Ctrl-Shift-F shows the popup as expected. jasonjgwhite@ - Could you please check the attached screen cast and please let us know if anything missed from our end. Also if possible please provide a sample extension file/url to test the issue from our end. A screen cast showing the issue if provided will be more helpful in triaging. Thanks...!!
,
Nov 2
Hi, krajshree, please find attached a minimal test case of a non-working example extension. The only thing I changed was the keyboard shortcut. This is covered in more detail in my previous post. I encourage you to try a few different keyboard shortcuts to identify the problem and help diagnose what's going wrong and how to fix it. Thanks!
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by woxxom@gmail.com
, Nov 1