New issue
Advanced search Search tips

Issue 900926 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

ReportingBrowserTest.CrashReport failing on win-asan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 1

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of lunalu@google.com

c105c81d-66b3-440f-9dee-59528f4f2dcd

Builders failed on: 
- win-asan: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan



 
Owner: paulmeyer@chromium.org
Hi Paul could you please investigate this
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baab4569cad597683b6127e012e1bc98caf70f60

commit baab4569cad597683b6127e012e1bc98caf70f60
Author: Paul Meyer <paulmeyer@chromium.org>
Date: Thu Nov 01 18:04:40 2018

Prevent ReportingBrowserTest.CrashReport from running on ASan bots.

This test is meant to crash the render process intentionally, and so
should not be run on ASan bots.

Bug:  900926 
Change-Id: I0399dcbccf7974684837ab43c5f00892cce07b0b
Reviewed-on: https://chromium-review.googlesource.com/c/1312979
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604638}
[modify] https://crrev.com/baab4569cad597683b6127e012e1bc98caf70f60/chrome/browser/net/reporting_browsertest.cc

Status: Fixed (was: Started)
Labels: -Pri-2 Pri-1
Status: Assigned (was: Fixed)
This is happening again, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/2050

I think it started on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/2033.
The log from 2033
==============
[ RUN      ] ReportingBrowserTest.CrashReport
[3532:436:1031/163359.941:WARNING:chrome_browser_main_win.cc(647)] Command line too long for RegisterApplicationRestart:  --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=ReportingBrowserTest.CrashReport --no-sandbox --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/mojo.fyi.network_browser_tests.filter --test-launcher-output="C:\b\s\w\it9ujgxr\scoped_dir8420_30162\results8420_23807\test_results.xml" --test-launcher-summary-output="C:\b\s\w\ioqnrgse\output.json" --user-data-dir="C:\b\s\w\it9ujgxr\scoped_dir8420_30162\d8420_11256" --disable-offline-auto-reload --use-mock-cert-verifier-for-testing --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --browser-test --ipc-connection-timeout=90 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=CrashReporting,NetworkErrorLogging,NetworkService,Reporting,TestFeatureForBrowserTest1 --disable-features=TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release_x64\gen" --restore-last-session about:blank
[3532:5836:1031/163400.719:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[1692:7280:1031/163402.026:ERROR:render_frame_impl.cc(1062)] Intentionally crashing (with null pointer dereference) because user navigated to chrome://crash/
=================================================================
==1692==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000000 (pc 0x7ff656dd6dda bp 0x00e2d936c4b0 sp 0x00e2d936b710 T0)
==1692==The signal is caused by a WRITE memory access.
==1692==Hint: address points to the zero page.
==1692==*** WARNING: Failed to initialize DbgHelp!              ***
==1692==*** Most likely this means that the app is already      ***
==1692==*** using DbgHelp, possibly with incompatible flags.    ***
==1692==*** Due to technical reasons, symbolization might crash ***
==1692==*** or produce wrong results.                           ***
    #0 0x7ff656dd6dd9 in content::internal::CrashIntentionally C:\b\swarming\w\ir\cache\builder\src\content\renderer\crash_helpers.cc:23
    #1 0x7ff65281a657 in content::HandleChromeDebugURL C:\b\swarming\w\ir\cache\builder\src\content\renderer\render_frame_impl.cc:1064
    #2 0x7ff65285bb8c in content::RenderFrameImpl::HandleRendererDebugURL C:\b\swarming\w\ir\cache\builder\src\content\renderer\render_frame_impl.cc:3588
    #3 0x7ff648675326 in content::mojom::FrameNavigationControlStubDispatch::Accept C:\b\swarming\w\ir\cache\builder\src\out\Release_x64\gen\content\common\frame.mojom.cc:1622
    #4 0x7ff64fb55430 in mojo::InterfaceEndpointClient::HandleValidatedMessage C:\b\swarming\w\ir\cache\builder\src\mojo\public\cpp\bindings\lib\interface_endpoint_client.cc:423
    #5 0x7ff6540bb97a in IPC::`anonymous namespace'::ChannelAssociatedGroupController::AcceptOnProxyThread C:\b\swarming\w\ir\cache\builder\src\ipc\ipc_mojo_bootstrap.cc:877
    #6 0x7ff6540b0e8b in base::internal::Invoker<base::internal::BindState<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message),scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>,base::internal::PassedWrapper<mojo::Message> >,void ()>::Run C:\b\swarming\w\ir\cache\builder\src\base\bind_internal.h:671
    #7 0x7ff652d0f9b3 in base::debug::TaskAnnotator::RunTask C:\b\swarming\w\ir\cache\builder\src\base\debug\task_annotator.cc:99
    #8 0x7ff652d58049 in base::sequence_manager::internal::ThreadControllerImpl::DoWork C:\b\swarming\w\ir\cache\builder\src\base\task\sequence_manager\thread_controller_impl.cc:196
    #9 0x7ff652d0f9b3 in base::debug::TaskAnnotator::RunTask C:\b\swarming\w\ir\cache\builder\src\base\debug\task_annotator.cc:99
    #10 0x7ff64e82add8 in base::MessageLoop::RunTask C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_loop.cc:545
    #11 0x7ff64e82bb7f in base::MessageLoop::DoWork C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_loop.cc:628
    #12 0x7ff652d190c8 in base::MessagePumpDefault::Run C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_pump_default.cc:37
    #13 0x7ff64e8b9b94 in base::RunLoop::Run C:\b\swarming\w\ir\cache\builder\src\base\run_loop.cc:102
    #14 0x7ff6528de258 in content::RendererMain C:\b\swarming\w\ir\cache\builder\src\content\renderer\renderer_main.cc:202
    #15 0x7ff64df60701 in content::ContentMainRunnerImpl::Run C:\b\swarming\w\ir\cache\builder\src\content\app\content_main_runner_impl.cc:906
    #16 0x7ff6512148cc in service_manager::Main C:\b\swarming\w\ir\cache\builder\src\services\service_manager\embedder\main.cc:472
    #17 0x7ff64df5ebc8 in content::ContentMain C:\b\swarming\w\ir\cache\builder\src\content\app\content_main.cc:19
    #18 0x7ff64f290dd9 in content::LaunchTests C:\b\swarming\w\ir\cache\builder\src\content\public\test\test_launcher.cc:637
    #19 0x7ff65e42676a in LaunchChromeTests C:\b\swarming\w\ir\cache\builder\src\chrome\test\base\chrome_test_launcher.cc:182
    #20 0x7ff65e4257c5 in main C:\b\swarming\w\ir\cache\builder\src\chrome\test\base\browser_tests_main.cc:36
    #21 0x7ff65e451cb7 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    #22 0x7ffe24342773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #23 0x7ffe24890d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)
==========
The fix is in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/2044, which also failed, thus, the fix does not work.
The fix does not replace the test name with "MAYBE_" test name.
I will land a fix to the fix :)
https://chromium-review.googlesource.com/c/chromium/src/+/1313932
Cc: vitaliii@chromium.org
The CL is in CQ.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/446a612d308e385f60b082f458ee18c0215f1458

commit 446a612d308e385f60b082f458ee18c0215f1458
Author: vitaliii <vitaliii@chromium.org>
Date: Fri Nov 02 11:35:02 2018

Followup to "Prevent ReportingBrowserTest.CrashReport from running on.."

This is a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1312979.

TBR=paulmeyer@chromium.org

Bug:  900926 
Change-Id: I9dd7dec6f30166fad651e3f281738b8b91c27b88
Reviewed-on: https://chromium-review.googlesource.com/c/1313932
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604891}
[modify] https://crrev.com/446a612d308e385f60b082f458ee18c0215f1458/chrome/browser/net/reporting_browsertest.cc

Sign in to add a comment