[LayoutNG] DCHECK failure in ComputeAbsoluteHorizontal at amazon.com |
||
Issue descriptionSTEPS: 1. Open https://www.amazon.com in content_shell with LayoutNG enabled. Sync'ed to ToT but still happens. [1:1:1101/222732.245252:FATAL:ng_absolute_utils.cc(284)] Check failed: container_size.width == *left + *right + *margin_left + *margin_right + *width ("266.672" vs. "266.656") #0 0x7f32a3bab79d base::debug::StackTrace::StackTrace() #1 0x7f32a38a5e1a base::debug::StackTrace::StackTrace() #2 0x7f32a3917beb logging::LogMessage::~LogMessage() #3 0x7f328e9d3685 blink::(anonymous namespace)::ComputeAbsoluteHorizontal() #4 0x7f328e9d2037 blink::ComputePartialAbsoluteWithChildInlineSize() #5 0x7f328ea100f5 blink::NGOutOfFlowLayoutPart::LayoutDescendant() #6 0x7f328ea0e878 blink::NGOutOfFlowLayoutPart::Run() #7 0x7f328e9da7e5 blink::NGBlockLayoutAlgorithm::Layout() #8 0x7f328e9eabd9 blink::(anonymous namespace)::LayoutWithAlgorithm() #9 0x7f328e9e99f7 blink::NGBlockNode::Layout() #10 0x7f328ea05bc3 blink::NGLayoutInputNode::Layout() #11 0x7f328e9dd9de blink::NGBlockLayoutAlgorithm::HandleInflow() #12 0x7f328e9d9a75 blink::NGBlockLayoutAlgorithm::Layout() #13 0x7f328e9eabd9 blink::(anonymous namespace)::LayoutWithAlgorithm() #14 0x7f328e9e99f7 blink::NGBlockNode::Layout() #15 0x7f328ea05bc3 blink::NGLayoutInputNode::Layout() #16 0x7f328e9dd9de blink::NGBlockLayoutAlgorithm::HandleInflow() #17 0x7f328e9d9a75 blink::NGBlockLayoutAlgorithm::Layout() #18 0x7f328e9eabd9 blink::(anonymous namespace)::LayoutWithAlgorithm() #19 0x7f328e9e99f7 blink::NGBlockNode::Layout() #20 0x7f328ea05bc3 blink::NGLayoutInputNode::Layout() #21 0x7f328e9dd9de blink::NGBlockLayoutAlgorithm::HandleInflow() #22 0x7f328e9d9a75 blink::NGBlockLayoutAlgorithm::Layout() #23 0x7f328e9eabd9 blink::(anonymous namespace)::LayoutWithAlgorithm() #24 0x7f328e9e99f7 blink::NGBlockNode::Layout() #25 0x7f328e9e17a3 blink::NGBlockLayoutAlgorithm::LayoutNewFormattingContext() @atotic, can you take a look?
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de919047744065673124f18a75d85aaf0e9605ff commit de919047744065673124f18a75d85aaf0e9605ff Author: Aleks Totic <atotic@chromium.org> Date: Thu Nov 01 19:47:18 2018 [LayoutNG] Fix margin rounding DCHECK Bug: 900921 Change-Id: I4ce730d9fefb2b099cacc113d951238d302f8cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1313168 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#604675} [modify] https://crrev.com/de919047744065673124f18a75d85aaf0e9605ff/third_party/blink/renderer/core/layout/ng/ng_absolute_utils.cc
,
Nov 1
,
Nov 2
Awesome, you're so fast! Thank you. |
||
►
Sign in to add a comment |
||
Comment 1 by atotic@chromium.org
, Nov 1