Binary size alert threshold is different than android-binary-size bot |
||||
Issue descriptionThis CL passed android-binary-size since it was under the threshold: https://crrev.com/c/1292008 Normalized APK Size: expected max: 16384 bytes, got 16205 bytes But it raised an alert: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQj4qNmQoM In go/binary-size-alerts it is 15.8KiB, which is 16179 bytes. The bot and the alert should be an if and only if relationship. One should imply the other.
,
Nov 1
I didn't find exact alert threshold, but just one alert that fired at 15.8KiB, not sure if actual alert level is lower. I wouldn't be surprised though if it's just a simple 16000.
,
Nov 1
I found this repo but I haven't found the code for generating alerts: https://chromium.googlesource.com/catapult.git/+/master/dashboard/dashboard/alerts.py
,
Nov 1
+jparent@ Hi Julie, would you mind helping us find the threshold for the binary size perf alert?
,
Nov 1
cc'ed a few folks who might be able to help
,
Nov 1
In the group_report link in #0, click the alert, scroll through the tooltip, click "Debug alert": https://chromeperf.appspot.com/debug_alert?test_path=ChromiumPerf/Android%20Builder%20Perf/resource_sizes%20(MonochromePublic.apk)/MonochromePublic.apk_Specifics/normalized%20apk%20size&rev=604323 Threshold configuration is currently: { "max_window_size": 2, "min_absolute_change": 16000, "min_relative_change": 0, "min_segment_size": 0 } estevenson: please update that configuration as desired. Let me know if you run into any issues.
,
Nov 1
Changed to 16384 to match the trybot, thanks! Reloading the page shows the new min_absolute_change as 16384, but when I click on "debug alert" again it's still showing as 16000 - anything else I need to do besides change the value and click "Update"?
,
Nov 2
Huh, it looks like that Update button was never wired up. :-/ /edit_anomaly_configs is only accessible to admins, so I changed the config for you there.
,
Nov 2
Great, thanks Ben! |
||||
►
Sign in to add a comment |
||||
Comment 1 by estevenson@chromium.org
, Nov 1Status: Assigned (was: Available)