New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 900914 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Binary size alert threshold is different than android-binary-size bot

Project Member Reported by wnwen@chromium.org, Nov 1

Issue description

This CL passed android-binary-size since it was under the threshold: https://crrev.com/c/1292008

Normalized APK Size: expected max: 16384 bytes, got 16205 bytes

But it raised an alert: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQj4qNmQoM

In go/binary-size-alerts it is 15.8KiB, which is 16179 bytes.

The bot and the alert should be an if and only if relationship. One should imply the other.
 
Owner: estevenson@chromium.org
Status: Assigned (was: Available)
Thanks for catching this! Will update the trybot threshold.

Curious where you found the alert threshold?
I didn't find exact alert threshold, but just one alert that fired at 15.8KiB, not sure if actual alert level is lower. I wouldn't be surprised though if it's just a simple 16000.
I found this repo but I haven't found the code for generating alerts: https://chromium.googlesource.com/catapult.git/+/master/dashboard/dashboard/alerts.py
Cc: jparent@chromium.org
+jparent@ Hi Julie, would you mind helping us find the threshold for the binary size perf alert?
Cc: benjhayden@chromium.org dtu@chromium.org seanmccullough@chromium.org
cc'ed a few folks who might be able to help
In the group_report link in #0, click the alert, scroll through the tooltip, click "Debug alert":

https://chromeperf.appspot.com/debug_alert?test_path=ChromiumPerf/Android%20Builder%20Perf/resource_sizes%20(MonochromePublic.apk)/MonochromePublic.apk_Specifics/normalized%20apk%20size&rev=604323

Threshold configuration is currently:
{
  "max_window_size": 2, 
  "min_absolute_change": 16000, 
  "min_relative_change": 0, 
  "min_segment_size": 0
}

estevenson: please update that configuration as desired. Let me know if you run into any issues.
Changed to 16384 to match the trybot, thanks!

Reloading the page shows the new min_absolute_change as 16384, but when I click on "debug alert" again it's still showing as 16000 - anything else I need to do besides change the value and click "Update"?
Huh, it looks like that Update button was never wired up. :-/

/edit_anomaly_configs is only accessible to admins, so I changed the config for you there.
Status: Fixed (was: Assigned)
Great, thanks Ben!

Sign in to add a comment