Official lint from android's website is over a year old: https://developer.android.com/studio/releases/sdk-tools Latest: 26.1.1 Google maven repository lint is up to date: https://dl.google.com/dl/android/maven2/index.html Latest: 26.4.0-alpha02 In order to get bug fixes and better checks, we need updated lint.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9da2eb810c82330055acae00374d96133a86c28f commit 9da2eb810c82330055acae00374d96133a86c28f Author: Peter Wen <wnwen@chromium.org> Date: Thu Nov 01 17:56:11 2018 Android: Clean up android_deps licenses Commands used: - `rm -rf third_party/android_deps/libs/[!O]*` - `tools/android/roll/android_deps/fetch_all.py --update-all` Added text license for GNU v2 with classpath exception since one dep was downloading a full html page for it. Bug: 900912 Change-Id: Ib3213d41259da0921e9d66cea2d08af2f29d383c Reviewed-on: https://chromium-review.googlesource.com/c/1312563 Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604636} [modify] https://crrev.com/9da2eb810c82330055acae00374d96133a86c28f/third_party/android_deps/libs/com_google_errorprone_javac_shaded/LICENSE [modify] https://crrev.com/9da2eb810c82330055acae00374d96133a86c28f/third_party/android_deps/libs/com_squareup_javapoet/README.chromium [modify] https://crrev.com/9da2eb810c82330055acae00374d96133a86c28f/third_party/android_deps/libs/org_checkerframework_checker_compat_qual/LICENSE [add] https://crrev.com/9da2eb810c82330055acae00374d96133a86c28f/third_party/android_deps/licenses/GNU_v2_with_Classpath_Exception_1991.txt [modify] https://crrev.com/9da2eb810c82330055acae00374d96133a86c28f/tools/android/roll/android_deps/buildSrc/src/main/groovy/ChromiumDepGraph.groovy
The following revision refers to this bug: https://chromium.googlesource.com/android_tools/+/81a57e30579c5f07a7b1276f9810a873d2344bfc commit 81a57e30579c5f07a7b1276f9810a873d2344bfc Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 07 15:43:46 2018 Add tools-lint directory to keep lint up to date Extracted from sdk-repo-linux-tools-5105688.zip Bug: 900912 Change-Id: I83023c1b7a8e17e9b5e8852e8e7030e6b078eacf Reviewed-on: https://chromium-review.googlesource.com/c/1313429 Reviewed-by: agrieve <agrieve@chromium.org> [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/trove4j-20160824.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/sdkmanager [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/archquery-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/osgi-4.0.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/apkanalyzer-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/shared.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/chimpchat-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jfreechart-swt-1.0.9.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/sdklib-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/jobb [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/asm-commons-6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/httpclient-4.5.2.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/swtmenubar-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/protos-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/builder-model-3.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/asm-analysis-6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/httpmime-4.5.2.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/explainer.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/x86/swt.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/lint-gradle-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/annotations-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/commons-codec-1.9.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/checker-qual-2.5.2.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/avdmanager [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/asm-tree-6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/commons-logging-1.2.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/binary-resources-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/dexlib2-2.2.4.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kotlin-stdlib-1.2.71.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jobb-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/org-eclipse-equinox-common-3.6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/apkanalyzer-cli-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/annotations-13.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jcommon-1.0.12.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/istack-commons-runtime-2.21.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/javax.inject-1.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jsr305-3.0.2.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/uast-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/common-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jaxb-runtime-2.2.11.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/intellij-core-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/manifest-merger-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/fastutil-7.2.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kotlin-reflect-1.2.71.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/javawriter-2.5.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/monkeyrunner-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/j2objc-annotations-1.1.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/org-eclipse-jface-3.6.2.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/error_prone_annotations-2.1.3.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jaxb-core-2.2.11.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/uiautomatorviewer [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/layoutlib-api-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/animal-sniffer-annotations-1.14.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/hierarchyviewer2lib-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/tracker-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/ddmuilib-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kotlin-stdlib-jdk7-1.2.71.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/gson-2.8.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/asm-util-6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/dvlib-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/baksmali-2.2.4.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/protobuf-java-3.4.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kotlin-stdlib-jdk8-1.2.71.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/ddms-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/traceview-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jfreechart-1.0.9.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/generator.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/lint-checks-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/uiautomatorviewer-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/source.properties [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/bcprov-jdk15on-1.56.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/javax.activation-1.2.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/lint-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/FastInfoset-1.2.13.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jython-standalone-2.5.3.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/NOTICE.txt [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kxml2-2.3.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/bcpkix-jdk15on-1.56.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kotlin-compiler-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/x86_64/swt.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/groovy-all-2.4.15.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/json-simple-1.1.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/fakeadbserver-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/archquery [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/kotlin-stdlib-common-1.2.71.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/monkeyrunner [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/stax-ex-1.7.7.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jsilver-1.0.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jimfs-1.1.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/lint-gradle-api-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/util-2.2.4.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jopt-simple-4.9.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/ddmlib-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/screenshot2-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/txw2-2.2.11.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/sdk-common-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/screenshot2 [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/lint [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/bin/apkanalyzer [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/shared-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jcommander-1.64.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/fat32lib.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/asm-6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/jaxb-api-2.2.12-b140109.1041.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/httpcore-4.4.5.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/lint-api-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/repository-26.4.0-dev.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/commons-compress-1.12.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/org-eclipse-core-commands-3.6.0.jar [add] https://crrev.com/81a57e30579c5f07a7b1276f9810a873d2344bfc/sdk/tools-lint/lib/guava-26.0-jre.jar
The following revision refers to this bug: https://chromium.googlesource.com/android_tools/+/6fecaa542f73dd5aeed170d9a4cf340159b42976 commit 6fecaa542f73dd5aeed170d9a4cf340159b42976 Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 07 17:56:44 2018 Update README and prepare to delete ndk dir - Add tools-lint update instructions - Delete references to ndk since it is now under third_party/android_ndk - Will delete ndk dir in follow-up CL Bug: 900912 Change-Id: Ia8adb9e37c848ca2b2f0d5526f15553004d4994b Reviewed-on: https://chromium-review.googlesource.com/c/1323470 Reviewed-by: agrieve <agrieve@chromium.org> [modify] https://crrev.com/6fecaa542f73dd5aeed170d9a4cf340159b42976/README.chromium
The following revision refers to this bug: https://chromium.googlesource.com/android_tools/+/32e0d5f807b17399ca50b903b93aa4a4c8794df4 commit 32e0d5f807b17399ca50b903b93aa4a4c8794df4 Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 07 18:27:33 2018 Remove ndk from gitignore - Follow-up CL. - Adds back sdk/ndk-bundle to the repo. Bug: 900912 Change-Id: I76e795ecd07b002059075487312c41547bb94d02 Reviewed-on: https://chromium-review.googlesource.com/c/1323472 Reviewed-by: agrieve <agrieve@chromium.org> [add] https://crrev.com/32e0d5f807b17399ca50b903b93aa4a4c8794df4/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/utils/libcxx/ndk/test/format.py [add] https://crrev.com/32e0d5f807b17399ca50b903b93aa4a4c8794df4/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/utils/libcxx/ndk/__init__.py [add] https://crrev.com/32e0d5f807b17399ca50b903b93aa4a4c8794df4/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/utils/libcxx/ndk/test/config.py [modify] https://crrev.com/32e0d5f807b17399ca50b903b93aa4a4c8794df4/.gitignore [add] https://crrev.com/32e0d5f807b17399ca50b903b93aa4a4c8794df4/sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/utils/libcxx/ndk/test/__init__.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9531c4aae5caacda7c14858de3860efb41228b4 commit a9531c4aae5caacda7c14858de3860efb41228b4 Author: Peter Wen <wnwen@chromium.org> Date: Thu Nov 08 22:47:20 2018 Android: Roll android_tools and fix lint errors Update lint to version 26.4.0-alpha03+. This is the first lint update since 2017 September, thus a long list of TODOs is expected. TBR for mechanical fixes to existing lint errors that are only exposed due to update. TBR=mheikal@chromium.org Bug: 900912 Change-Id: I3335834ae308a3411ced51bb2c913b76a8f8d8c3 Reviewed-on: https://chromium-review.googlesource.com/c/1327157 Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606631} [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/DEPS [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/android_webview/java/src/org/chromium/android_webview/AwSettings.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/android_webview/java/src/org/chromium/android_webview/CleanupReference.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/android_webview/tools/automated_ui_tests/java/res/layout/edittext_webview.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/build/android/gyp/lint.py [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/build/android/lint/suppressions.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/build/config/android/internal_rules.gni [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/drawable/download_home_tabs_bg.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/autofill_local_card_editor.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/autofill_name_fixflow.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/homepage_editor.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/new_tab_page_layout.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/password_entry_exception.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/payments_request_editor_textview.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/layout/search_toolbar.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/values-v19/values.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/res_download/layout/download_manager_section_header.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/remoting/android/java/res/layout/pin_dialog.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/tools/android/customtabs_benchmark/res/layout/main.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/ui/android/java/res/values/dimens.xml [modify] https://crrev.com/a9531c4aae5caacda7c14858de3860efb41228b4/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/755ab00005f764b004eddb9637caaa56c25a75b2 commit 755ab00005f764b004eddb9637caaa56c25a75b2 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Nov 08 23:48:20 2018 Revert "Android: Roll android_tools and fix lint errors" This reverts commit a9531c4aae5caacda7c14858de3860efb41228b4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 606631 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E5NTMxYzRhYWU1Y2FhY2RhN2MxNDg1OGRlMzg2MGVmYjQxMjI4YjQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/4213 Sample Failed Step: compile Original change's description: > Android: Roll android_tools and fix lint errors > > Update lint to version 26.4.0-alpha03+. > > This is the first lint update since 2017 September, thus a long list of > TODOs is expected. > > TBR for mechanical fixes to existing lint errors that are only exposed > due to update. > > TBR=mheikal@chromium.org > > Bug: 900912 > Change-Id: I3335834ae308a3411ced51bb2c913b76a8f8d8c3 > Reviewed-on: https://chromium-review.googlesource.com/c/1327157 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606631} Change-Id: Ie3a61a6d093d8cd6426ddcd7bf833f98c9b4f78c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900912 Reviewed-on: https://chromium-review.googlesource.com/c/1327611 Cr-Commit-Position: refs/heads/master@{#606646} [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/DEPS [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/android_webview/java/src/org/chromium/android_webview/AwSettings.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/android_webview/java/src/org/chromium/android_webview/CleanupReference.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/android_webview/tools/automated_ui_tests/java/res/layout/edittext_webview.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/build/android/gyp/lint.py [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/build/android/lint/suppressions.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/build/config/android/internal_rules.gni [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/drawable/download_home_tabs_bg.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/autofill_local_card_editor.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/autofill_name_fixflow.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/homepage_editor.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/new_tab_page_layout.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/password_entry_exception.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/payments_request_editor_textview.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/layout/search_toolbar.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/values-v19/values.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/res_download/layout/download_manager_section_header.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/remoting/android/java/res/layout/pin_dialog.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/tools/android/customtabs_benchmark/res/layout/main.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/ui/android/java/res/values/dimens.xml [modify] https://crrev.com/755ab00005f764b004eddb9637caaa56c25a75b2/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17d65456ded0266780043ad36af3920fda63e482 commit 17d65456ded0266780043ad36af3920fda63e482 Author: Peter Wen <wnwen@chromium.org> Date: Mon Nov 12 15:22:43 2018 Reland "Android: Roll android_tools and fix lint errors" Original CL: https://crrev.com/c/1327157 Fixes: - Cronet target: cronet_sample_apk_java__lint - Removes suppression for autofill TBR=mheikal@chromium.org Bug: 900912 Change-Id: Ib3c7fd69e394ade0b2b80aed72a993e02b0a153c Reviewed-on: https://chromium-review.googlesource.com/c/1331011 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607231} [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/DEPS [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/android_webview/java/src/org/chromium/android_webview/AwSettings.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/android_webview/java/src/org/chromium/android_webview/CleanupReference.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebkitToCompatConverterAdapter.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/android_webview/tools/automated_ui_tests/java/res/layout/edittext_webview.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/build/android/gyp/lint.py [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/build/android/lint/suppressions.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/build/config/android/internal_rules.gni [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/drawable/download_home_tabs_bg.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/autofill_local_card_editor.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/autofill_name_fixflow.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/homepage_editor.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/new_tab_page_layout.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/password_entry_exception.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/payments_request_editor_textview.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/layout/search_toolbar.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/values-v19/values.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/res_download/layout/download_manager_section_header.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/components/cronet/android/sample/res/layout/dialog_url.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/remoting/android/java/res/layout/pin_dialog.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/tools/android/customtabs_benchmark/res/layout/main.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/ui/android/java/res/values/dimens.xml [modify] https://crrev.com/17d65456ded0266780043ad36af3920fda63e482/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/fb6fd4b0056cc07cdf1a5c6753722e822b25917c commit fb6fd4b0056cc07cdf1a5c6753722e822b25917c Author: Yves Gerey <yvesg@webrtc.org> Date: Wed Nov 14 10:11:47 2018 Fix lint errors for android manifests. This is needed to roll android_tools which comes with udpated lint. See https://chromium-review.googlesource.com/c/chromium/src/+/1331011 Bug: chromium:900912 Change-Id: Ib0a0fb8fdd14269ff84fa99b5c63878f2b3d9fb6 Reviewed-on: https://webrtc-review.googlesource.com/c/110861 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Yves Gerey <yvesg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25632} [modify] https://crrev.com/fb6fd4b0056cc07cdf1a5c6753722e822b25917c/examples/androidapp/AndroidManifest.xml [modify] https://crrev.com/fb6fd4b0056cc07cdf1a5c6753722e822b25917c/examples/androidapp/res/layout/activity_connect.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7f70c16998abd53ebd1c3083a9032fcc051ee41 commit e7f70c16998abd53ebd1c3083a9032fcc051ee41 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Nov 14 15:41:27 2018 Roll src/third_party/webrtc c58c8a54224d..76f9954b17a4 (5 commits) https://webrtc.googlesource.com/src.git/+log/c58c8a54224d..76f9954b17a4 git log c58c8a54224d..76f9954b17a4 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 terelius@webrtc.org Remove the old RTC event log parser. 2018-11-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db720b4ab9..fbed28d429 (606025:607938) 2018-11-14 yvesg@webrtc.org Less strict audio codec tests to accomodate opus switch to SSE. 2018-11-14 yvesg@webrtc.org Fix lint errors for android manifests. 2018-11-14 mbonadei@webrtc.org Rectify comment about 'build_with_chromium'. Created with: gclient setdep -r src/third_party/webrtc@76f9954b17a4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:900912 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b3cfb1fa144d2aaf6dcffc1c1968642403d327c Reviewed-on: https://chromium-review.googlesource.com/c/1335772 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607987} [modify] https://crrev.com/e7f70c16998abd53ebd1c3083a9032fcc051ee41/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adfee172b0ba6262283d258fe1bfef55d940a178 commit adfee172b0ba6262283d258fe1bfef55d940a178 Author: Peter Wen <wnwen@chromium.org> Date: Mon Nov 19 16:52:11 2018 Android: Remove 1 lint suppression This suppression was added for autofill assistant, but now that https://crrev.com/c/1340160 has landed, it is no longer necessary. Bug: 900912 Change-Id: I69cd099762c4c66d88b1c56ecd948cd2f12a1cd3 Reviewed-on: https://chromium-review.googlesource.com/c/1340512 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609332} [modify] https://crrev.com/adfee172b0ba6262283d258fe1bfef55d940a178/build/android/lint/suppressions.xml
Still should be updated regularly, but this is good for now.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a11f498ff6fd68256a6d37218b23074c847e0f37 commit a11f498ff6fd68256a6d37218b23074c847e0f37 Author: Drew Stonebraker <stonebraker@chromium.org> Date: Mon Jan 07 20:45:20 2019 Disable autofill for WebView Shell url bar Added importantForAutofill="no" attribute to url bar EditText. Removed tools:ignore="Autofill" attribute from url bar, as it is now obsolete. Also removed TODO comment for removing the lint ignore, which referenced issue 900912 . ninja build succeeded without lint error. Bug: 916000 , 900912 Test: AutoFillManager no longer outputs to logcat on input focus. Change-Id: Icfbdf9dad518505f3ed42e28bad774b5701aad93 Reviewed-on: https://chromium-review.googlesource.com/c/1381519 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#620457} [modify] https://crrev.com/a11f498ff6fd68256a6d37218b23074c847e0f37/android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml
Comment 1 by wnwen@chromium.org
, Nov 1