New issue
Advanced search Search tips

Issue 900870 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app switches from My files to Downloads when mounts change

Project Member Reported by sa...@chromium.org, Nov 1

Issue description

What steps will reproduce the problem?
(1) In one Files app window select My files
(2) In a second Files app window, open a zip, mounting it


What is the expected result?
The first window should remain in My files.

What happens instead?
The first window navigates to Downloads.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a122897620527d271cac5bf9b15e1e8de02978ad

commit a122897620527d271cac5bf9b15e1e8de02978ad
Author: Sam McNally <sammc@chromium.org>
Date: Mon Nov 05 01:20:02 2018

Don't switch to the default display root if the current entry is fake.

If a FakeItem is the current entry and a volume is mounted or unmounted,
Files app switches to the default display root since the FakeItem
doesn't have a VolumeInfo. Omit switching if the current root is not a
native entry.

Bug:  900870 
Change-Id: I943959112135ceb5752207f87e6810a4ec60ae0f
Reviewed-on: https://chromium-review.googlesource.com/c/1312148
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605221}
[modify] https://crrev.com/a122897620527d271cac5bf9b15e1e8de02978ad/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/a122897620527d271cac5bf9b15e1e8de02978ad/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/a122897620527d271cac5bf9b15e1e8de02978ad/ui/file_manager/integration_tests/file_manager/file_display.js

Status: Fixed (was: Assigned)

Sign in to add a comment