Not M71 blocker.

Hi Manu, could you PTAL? Thanks! The issue seems to be that ShelfLayoutManager is computing the work area incorrectly when the virtual keyboard is up. Specifically, the work area is shrunk by both the shelf size and the virtual keyboard size, which is wrong (this is why you see a gap between the window and the keyboard; the gap's height is the shelf height). We should only shrink by the keyboard size because the keyboard  covers the shelf.

When the VK is up, we used to set the shelf size to 0 [1], so we only shrink by the keyboard size. I can't quite figure out how the current code works. Could it be related to https://chromium-review.googlesource.com/c/chromium/src/+/1290056 ?

[1] https://chromium.googlesource.com/chromium/src/+/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf_layout_manager.cc#792

I just (independently) did a bisect (because I thought I may have introduced this :) ) and the gap is caused by https://chromium-review.googlesource.com/c/1290056.

Thanks Steven for verifying & bisecting :)

 Issue 899626  has been merged into this issue.

 Issue 906672  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba496217cdb56b7c9e49504b47638bafe983b197

commit ba496217cdb56b7c9e49504b47638bafe983b197
Author: Manu Cornet <manucornet@chromium.org>
Date: Mon Dec 17 17:51:28 2018

CrOS shelf: don't restrict work area further when keyboard is shown

Currently, when the virtual keyboard is shown, the work area is
restricted by the size of the keyboard, but also by the size of the
shelf. This is unnecessary because the keyboard hides the shelf
(regardless of the shelf position). Restricting the work area
further by the size of the shelf therefore creates an unnecessary
gap between open windows and the virtual keyboard.

Bug:  900869 
Change-Id: I3af4d34b3f4f6c3b9da5c399f09d736d96492dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1379955
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617151}
[modify] https://crrev.com/ba496217cdb56b7c9e49504b47638bafe983b197/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/ba496217cdb56b7c9e49504b47638bafe983b197/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/ba496217cdb56b7c9e49504b47638bafe983b197/ash/wm/pip/pip_positioner_unittest.cc

This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a9708ef9e7e5a6ac168cc2548f3cd3076759d2

commit 59a9708ef9e7e5a6ac168cc2548f3cd3076759d2
Author: Manu Cornet <manucornet@chromium.org>
Date: Wed Dec 19 04:47:53 2018

CrOS shelf: don't restrict work area further when keyboard is shown

Currently, when the virtual keyboard is shown, the work area is
restricted by the size of the keyboard, but also by the size of the
shelf. This is unnecessary because the keyboard hides the shelf
(regardless of the shelf position). Restricting the work area
further by the size of the shelf therefore creates an unnecessary
gap between open windows and the virtual keyboard.

Bug:  900869 
Change-Id: I3af4d34b3f4f6c3b9da5c399f09d736d96492dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1379955
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617151}(cherry picked from commit ba496217cdb56b7c9e49504b47638bafe983b197)
Reviewed-on: https://chromium-review.googlesource.com/c/1383592
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#462}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/59a9708ef9e7e5a6ac168cc2548f3cd3076759d2/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/59a9708ef9e7e5a6ac168cc2548f3cd3076759d2/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/59a9708ef9e7e5a6ac168cc2548f3cd3076759d2/ash/wm/pip/pip_positioner_unittest.cc

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 59a9708ef9e7e5a6ac168cc2548f3cd3076759d2 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/59a9708ef9e7e5a6ac168cc2548f3cd3076759d2

Commit: 59a9708ef9e7e5a6ac168cc2548f3cd3076759d2
Author: manucornet@chromium.org
Commiter: manucornet@chromium.org
Date: 2018-12-19 04:47:53 +0000 UTC

CrOS shelf: don't restrict work area further when keyboard is shown

Currently, when the virtual keyboard is shown, the work area is
restricted by the size of the keyboard, but also by the size of the
shelf. This is unnecessary because the keyboard hides the shelf
(regardless of the shelf position). Restricting the work area
further by the size of the shelf therefore creates an unnecessary
gap between open windows and the virtual keyboard.

Bug:  900869 
Change-Id: I3af4d34b3f4f6c3b9da5c399f09d736d96492dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1379955
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617151}(cherry picked from commit ba496217cdb56b7c9e49504b47638bafe983b197)
Reviewed-on: https://chromium-review.googlesource.com/c/1383592
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#462}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}