Flaky test: DesktopWindowTreeHostMusTest.WindowMoveShouldNotTransfersBack Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8644 Test output log: https://chromium-swarm.appspot.com/task?id=40e6a6d9ee53e210 Culprit (100.0% confidence): r604473 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyywELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKUAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzg2NDQvdmlld3NfbXVzX3VuaXR0ZXN0cy9SR1Z6YTNSdmNGZHBibVJ2ZDFSeVpXVkliM04wVFhWelZHVnpkQzVYYVc1a2IzZE5iM1psVTJodmRXeGtUbTkwVkhKaGJuTm1aWEp6UW1GamF3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20DesktopWindowTreeHostMusTest.WindowMoveShouldNotTransfersBack&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyywELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKUAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzg2NDQvdmlld3NfbXVzX3VuaXR0ZXN0cy9SR1Z6YTNSdmNGZHBibVJ2ZDFSeVpXVkliM04wVFhWelZHVnpkQzVYYVc1a2IzZE5iM1psVTJodmRXeGtUbTkwVkhKaGJuTm1aWEp6UW1GamF3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8993d59085b2eb5e4fd86cc477de01721fa3f789 commit 8993d59085b2eb5e4fd86cc477de01721fa3f789 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Nov 01 06:13:34 2018 Revert "Transfer touch events back to the original when the window move ends" This reverts commit 0b5ca9b697200ea57e0420beb147f4fa8fbd153d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 604473 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGI1Y2E5YjY5NzIwMGVhNTdlMDQyMGJlYjE0N2Y0ZmE4ZmJkMTUzZAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8644 Sample Failed Step: views_mus_unittests Sample Flaky Test: DesktopWindowTreeHostMusTest.WindowMoveShouldNotTransfersBack Original change's description: > Transfer touch events back to the original when the window move ends > > The current behavior makes TransferEventsTo() before the window > move starts, but don't care at its end. This causes errors like > crbug.com/900363 . But we can't simply transfer back to the original > window unconditionally since someone (like TabDragController) may > also want to continue dragging on a window other than the original > source window. > > This CL introduces a new scoped class to control this; it makes > TransferEventsTo first, and then invokes TransferEventsTo back > again at the end, but it skips invoking the second transfer if > someone else also transfers the touch events on the same window. > > BUG= 900363 > TEST=the new test case > > Change-Id: I81792872a13f0e4bb2c88b526c92cf689d656b71 > Reviewed-on: https://chromium-review.googlesource.com/c/1310501 > Commit-Queue: Jun Mukai <mukai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604473} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG= 900363 , 900848 Change-Id: Ie326f3b57b2869b0981beb73344fbb530ca21721 Reviewed-on: https://chromium-review.googlesource.com/c/1312613 Cr-Commit-Position: refs/heads/master@{#604528} [modify] https://crrev.com/8993d59085b2eb5e4fd86cc477de01721fa3f789/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/8993d59085b2eb5e4fd86cc477de01721fa3f789/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
does not look flaky anymore https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=views_mus_unittests&tests=DesktopWindowTreeHostMusTest.WindowMoveShouldNotTransfersBack
Comment 1 by bugdroid1@chromium.org
, Nov 1