Issue metadata
Sign in to add a comment
|
After scrolling, touch near bottom of page is ignored
Reported by
pja...@gmail.com,
Nov 1
|
||||||||||||||||||||||
Issue descriptionExample URL: https://duckduckgo.com/?q=test Steps to reproduce the problem: 1. Navigate to a page taller than the browser window. 2. Scroll the page until the OS navigation bar disappears and there's a link, button, text, or image near the bottom of the page. (Search results are good for this.) 3. Attempt to tap or select the link, button, text, or image. What is the expected behavior? The object should be activated (e.g. navigation should occur) or selected. What went wrong? The touch (short or long) is ignored. If you then scroll so the OS navigation bar appears again, you can touch or select the desired object. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Chrome 69 for sure, possibly Chrome 70 Does this work in other browsers? Yes Chrome version: 71.0.3578.31 Channel: beta OS Version: 8.1.0 Flash Version: Possibly related to 776451? (Just a guess.)
,
Nov 1
Thanks for the report, this sounds potentially pretty serious! I tried but was unable to reproduce this using Chrome 71.0.3578.31 for Android on a Pixel 2 XL. What device(s) does this reproduce on for you? Do you have any flags enabled in chrome://flags? Can you paste your "Variations" list from chrome://version here? In particular, you don't have the experiment that shows additional Chrome UI at the _bottom_ of the screen which hides on scroll, do you?
,
Nov 1
It is the Chrome bottom UI that shrinks out of the way, not the Android UI, you're right. However, I didn't enable it: when the phone updated to the new UI, the navigation was there. (I've attached screenshots; 163511 is where I couldn't tap, 163531 is where I was able to.) I'm on a Nexus 6P, Android 8.1.0 with the October patches. Here's the Variations list. The only flags that I've changed (I guess? I don't remember having done so, but they're highlighted) are three #enable-ntp-* values that seem to be related to content suggestions on the New Tab page. 411b6d4e-f23d1dea 7eb20865-3f4a17df 45514eb0-3f4a17df 8b81f22b-3f4a17df 609c5d64-a2d707c6 288ddd9a-a3a14831 a6c4c423-f23d1dea 853359fa-3f4a17df ec6a8bba-f23d1dea 2b6ab552-ca7d8d80 66df3e9d-5f3c1a6f ebeb14fc-3f4a17df 7e4bc10d-3f4a17df cc20827f-63a74b3e 38eb801c-3f4a17df ed32657-3f4a17df 1d773dec-3f4a17df 9def365c-5d0302cf 236d5d9e-6005c22c 47e5d3db-3d47f4f4 77207729-e0e232cc dc462a28-5c943877 125b7f68-898170a5 4bf94d2-26e7b859 d442dfb7-76280c7b 71ed337-7c7ea110 67941188-3d47f4f4 3f4a17df-3f4a17df a582a1b8-ad75ce17 e9de5187-ca7d8d80 8ee5ed19-ca7d8d80 74658432-ca7d8d80 785e78-f23d1dea 4426bdd3-48b9f718 5e3a236d-59e286d0 a348f31e-5d0302cf 784a7e92-53c860e5 93731dca-3d47f4f4 87a01a8d-ca7d8d80 9b4c4257-6ad6e56e 27f3523b-92f84df3 cfef46e7-f23d1dea c157e591-3f4a17df c364a20-3d47f4f4 566db8be-5c943877 1eebe54f-5c943877 4ea303a6-9fba3b4c 95876445-f2718d9f d92562a9-4d2fac87 67246da1-5d0302cf cc54eb06-33c3eba5 d4d220f9-1c10ba89 4932440-f23d1dea 2afd34e2-869c3507 51b9b54d-3f4a17df 4bc337ce-f483b7fd 17507c76-3f4a17df 494d8760-52325d43 3ac60855-486e2a9c f296190c-31d50f90 4442aae2-d7f6b13c ed1d377-e1cc0f14 75f0f0a0-d7f6b13c e2b18481-75cb33fc e7e71889-4ad60575 1e902a37-3f4a17df cc73f8a1-60e174b1 10a311eb-2b1ad591 8834fcca-cf4f6ead 6204e469-94a80f74
,
Nov 1
More specifics on the version info, if it helps: Google Chrome: 71.0.3578.31 (Official Build) beta (32-bit) Revision: c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427} OS: Android 8.1.0; Nexus 6P Build/OPM7.181005.003
,
Nov 2
,
Nov 2
Tested the issue on Android and was able to navigate to links at bottom of page when chrome address bar is hidden. Steps: 1.Open chrome >> Navigate to https://duckduckgo.com/?q=test 2.Scrolled till chrome address bar is hidden 3.Clicked on the bottom links >> Observed navigation to respective page upon clicking Chrome versions tested: 71.0.3578.31 OS: Android 8.1.0,9.0 Android Devices: Nexus 6p, Pixel 2 XL @Reporter: Could you please look at the above steps and let us know if anything is missed from our end. Note: Per c#0, cc'ng donnd@ from issue 776451 for further inputs. Thanks!
,
Nov 2
Those look like the correct steps. It's 100% reproducible here, including on this bug report itself, but not in Chrome non-beta, Firefox, or embedded views.
,
Nov 2
The inactive area is about 150% of the height of the area where the navigation icons would appear.
,
Nov 2
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 3
Worth noting that this happens in landscape too, as well as affecting video playback (the controls can't be used).
,
Nov 5
Navigation doesn't work at the bottom of the page? Making priority 0, we should bisect and address immediately. Matt, setting you as owner for now for further triage.
,
Nov 5
This is a bug with the Duet experiment exclusively, I'm in the process of looking into it.
,
Nov 5
For what it's worth, presuming Duet is controlled by chrome://flags#enable-chrome-duet, it's set to "Default", and the behaviour persists if I set it to "Disabled".
,
Nov 5
...although now that I've set it back to "Default", the menu and tab counter have returned to the top of the browser and the whole content area works as expected. (I definitely haven't enabled or changed this value myself until just now.)
,
Nov 6
Just to update, Re-tested the issue on Nexus 6p/Android 8 and Pixel 2 XL/Android 9 by enabling/disabling/default chrome://flags#enable-chrome-duet and issue is not reproducible from TE end. On scrolling and clicking on link that is present on bottom of page takes to selected page. Thanks!
,
Nov 6
#15, do you have display size set to something other than "default" in Android's settings? I've only experienced the issue with the Duet flag enabled (or on default if you're in the experiment). It is much more concerning if it happens without the bottom toolbar.
,
Nov 6
#17, both display size and font size are set to "small".
,
Nov 6
Ok, that seems to be the trigger. Something in our code isn't handling the small display size correctly; default and above shouldn't present this issue. I'll test to see if I can reproduce without the bottom toolbar. I'll start looking into it while we wait for test to do a bisect.
,
Nov 6
Issue 870574 has been merged into this issue.
,
Nov 6
Repro steps for testers: - Enable Chrome Duet - In android display settings, change display size to "small" - Navigate to reddit.com (or some other page with interactive things at the bottom) - Scroll to the bottom of the page so that top and bottom toolbars are off-screen. - Attempt to tap something at the bottom of the screen.
,
Nov 9
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Enabled chrome duet flag from chrome://flags 2. Changed display size to small 3. Opened chrome and navigated to reddit.com 4. Scrolled so that nav panel hides, clicked on bottom link and nothing happens on clicking Chrome versions tested: 70.0.3538.80 , 72.0.3605.3 OS: Android 9.0.0 Android Devices: Pixel XL Issue is seen from introduction of Chrome Duet flag in chrome://flags i.e; from M-69. Hence considering this issue as Non-Regression and removing Needs-Bisect label. Please navigate to below link for log's -- go/chrome-androidlogs/900843 Thanks!
,
Nov 13
Issue 904493 has been merged into this issue.
,
Dec 12
additional comments that found the same issue https://listnr.corp.google.com/product/282/report/85840423083 https://listnr.corp.google.com/product/282/report/85827299005 https://listnr.corp.google.com/product/282/report/85836221456 https://listnr.corp.google.com/product/282/report/85838619435 https://listnr.corp.google.com/product/282/report/85816818044 https://listnr.corp.google.com/product/282/report/85814470690 https://listnr.corp.google.com/product/282/report/85803002062 https://listnr.corp.google.com/product/282/report/85779485857 https://listnr.corp.google.com/product/282/report/85779350010 https://listnr.corp.google.com/product/282/report/85764608674 https://listnr.corp.google.com/product/282/report/85757259966
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/142db47c8bc675b00f87fc38b1d8c81da31fc8c9 commit 142db47c8bc675b00f87fc38b1d8c81da31fc8c9 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Dec 17 18:06:06 2018 Fix Duet touch issue at bottom of screen This patch fixes the issue with the bottom toolbar that would cause touches at the bottom of the screen to be ignored. When passing browser controls height around in code, the pixel value is converted between px and dp multiple times. Often times the decimal value is chopped off of the dp value as it is stored as an int. Long term, we should unify which unit we want to store height in to prevent this problem. For now, when converting the value to dp, we now always round up. Now in the worst case, the controls move slightly farther off-screen (where previously in these cases a few pixels would remain visible). Bug: 900843 Change-Id: I496879e4a53ac04f461d1b0591a2696962570bcf Reviewed-on: https://chromium-review.googlesource.com/c/1379397 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#617156} [modify] https://crrev.com/142db47c8bc675b00f87fc38b1d8c81da31fc8c9/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
,
Dec 17
,
Dec 17
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
This is regressed in M70. How safe and critical is to merge this change to M72 beta this late in release cycle?
,
Dec 17
The issue only occurs while the Duet experiment is enabled. There is a good chance we will launch in M72. The patch itself is safe in that it is very small (and easy to revert in the extremely unlikely event it causes an issue) and affects some numbers around how toolbars move. Unfortunately it does have a large impact on our users so it is blocking for us.
,
Dec 17
Approving merge to M72 branch 3626 based on comment #29 and per offline chat with mdjones@ Duet Experiment will be on Finch, so we can disabled it easily if needed. Pls merge ASAP.
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf3a1b9037d1eac1a4f294c11e85ca72f236b961 commit bf3a1b9037d1eac1a4f294c11e85ca72f236b961 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Dec 17 21:21:04 2018 Fix Duet touch issue at bottom of screen This patch fixes the issue with the bottom toolbar that would cause touches at the bottom of the screen to be ignored. When passing browser controls height around in code, the pixel value is converted between px and dp multiple times. Often times the decimal value is chopped off of the dp value as it is stored as an int. Long term, we should unify which unit we want to store height in to prevent this problem. For now, when converting the value to dp, we now always round up. Now in the worst case, the controls move slightly farther off-screen (where previously in these cases a few pixels would remain visible). TBR=mdjones@chromium.org (cherry picked from commit 142db47c8bc675b00f87fc38b1d8c81da31fc8c9) Bug: 900843 Change-Id: I496879e4a53ac04f461d1b0591a2696962570bcf Reviewed-on: https://chromium-review.googlesource.com/c/1379397 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617156} Reviewed-on: https://chromium-review.googlesource.com/c/1380677 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#406} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/bf3a1b9037d1eac1a4f294c11e85ca72f236b961/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
,
Dec 17
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf3a1b9037d1eac1a4f294c11e85ca72f236b961 Commit: bf3a1b9037d1eac1a4f294c11e85ca72f236b961 Author: mdjones@chromium.org Commiter: mdjones@chromium.org Date: 2018-12-17 21:21:04 +0000 UTC Fix Duet touch issue at bottom of screen This patch fixes the issue with the bottom toolbar that would cause touches at the bottom of the screen to be ignored. When passing browser controls height around in code, the pixel value is converted between px and dp multiple times. Often times the decimal value is chopped off of the dp value as it is stored as an int. Long term, we should unify which unit we want to store height in to prevent this problem. For now, when converting the value to dp, we now always round up. Now in the worst case, the controls move slightly farther off-screen (where previously in these cases a few pixels would remain visible). TBR=mdjones@chromium.org (cherry picked from commit 142db47c8bc675b00f87fc38b1d8c81da31fc8c9) Bug: 900843 Change-Id: I496879e4a53ac04f461d1b0591a2696962570bcf Reviewed-on: https://chromium-review.googlesource.com/c/1379397 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617156} Reviewed-on: https://chromium-review.googlesource.com/c/1380677 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#406} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbyers@chromium.org
, Nov 1Labels: -Type-Bug Type-Bug-Regression