New issue
Advanced search Search tips

Issue 900841 link

Starred by 2 users
Status: Fixed
Owner:
sidereal@google.com
Closed: Nov 8
Components:
EstimatedDays: 0
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

crostini_manager erroneously claims to fail to stop vm_concierge

Project Member Reported by sidereal@google.com, Nov 1 
Chrome Version: 72.0.3598.0
OS: ChromeOS

crostini_manager always logs "Failed to stop Concierge service" when uninstalling crostini, regardless of whether it succeeds or not.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93f66e0ee4f1b90c9a1c4e6a6754ba4b779be93d

commit 93f66e0ee4f1b90c9a1c4e6a6754ba4b779be93d
Author: Fergus Dall <sidereal@google.com>
Date: Thu Nov 08 02:02:04 2018

Assume stoping vm_concierge succeeds if we get an empty response

Currently, we assume that debugd sends back a boolean success/fail
value in the response when asked to shutdown vm_concierge, but in fact
the response is empty, resulting in spurious error messages. This CL
changes this behaviour to assume success when receving any response,
including an empty one.

Bug:  900841 
Change-Id: I04682973c6dc9d190d43c1626c9b4e05cfa35484
Reviewed-on: https://chromium-review.googlesource.com/c/1312140
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606284}
[modify] https://crrev.com/93f66e0ee4f1b90c9a1c4e6a6754ba4b779be93d/chromeos/dbus/debug_daemon_client.cc

Comment 2 by sidereal@google.com, Nov 8

Status: Fixed (was: Assigned)
Fixed by above CL
►

Sign in to add a comment